Ubuntu
python-glance-store package

FTBFS due to failing unit tests

Bug #1505632 reported by Łukasz Zemczak on 2015-10-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-glance-store (Ubuntu)	Fix Released	High	Łukasz Zemczak

Bug Description

As per the wily test-rebuild [1], it seems that the latest python-glance-store is failing due to broken unit tests. Seems relatively easy to fix. Part of the log:

======================================================================
FAIL: glance_store.tests.unit.test_swift_store.TestStoreAuthV1.test_read_acl_public
glance_store.tests.unit.test_swift_store.TestStoreAuthV1.test_read_acl_public
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "glance_store/tests/unit/test_swift_store.py", line 950, in test_read_acl_public
    store.set_acls(loc, public=True, context=ctxt)
  File "glance_store/_drivers/swift/store.py", line 918, in set_acls
    connection.post_container(location.container, headers=headers)
  File "/usr/lib/python2.7/dist-packages/swiftclient/client.py", line 1471, in post_container
    response_dict=response_dict)
  File "/usr/lib/python2.7/dist-packages/swiftclient/client.py", line 1390, in _retry
    service_token=self.service_token, **kwargs)
TypeError: fake_post_container() got an unexpected keyword argument 'service_token'
Traceback (most recent call last):
_StringException: Empty attachments:
  stderr
  stdout
(...)

[1] https://launchpadlibrarian.net/220829765/buildlog_ubuntu-wily-amd64.python-glance-store_0.9.1-1_BUILDING.txt.gz

Tags:

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2015-10-14:

Fix for build failure is available upstream, cherry-picking: https://github.com/openstack/glance_store/commit/f37947a7e083532676a9f2ed079dff6bdc19a8e9

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2015-10-14:

Cherry-pick fix from upstream Edit (2.1 KiB, text/plain)

Attaching the debdiff with a distropatch of the fix. Will forward this to Debian as soon as possible, but I suppose it's more important to resolve the FTBFS before wily release instantly.

Changed in python-glance-store (Ubuntu):
importance:	Undecided → High

Revision history for this message

Michael Terry (mterry) wrote on 2015-10-14:

Thanks for the patch! Remember to run "update-maintainer" when you introduce an Ubuntu delta on top of Debian. But other than that, worked great. :)

I've uploaded to wily.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-10-14:

This bug was fixed in the package python-glance-store - 0.9.1-1ubuntu1

---------------
python-glance-store (0.9.1-1ubuntu1) wily; urgency=medium

  * debian/patches/fix_swift_unit_tests.patch:
    - Cherry-pick fix from upstream for broken unit tests with swiftclient
      2.6.0 and higher (LP: #1505632).

-- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 14 Oct 2015 12:49:12 +0200