Mahara

Unable to remove a tagged journal option in 15.10

Bug #1508204 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Critical
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

When I go to remove a tag option in 15.10 the modal closes rather than removing the item.

To Test:

1) Add a few journal entries to your site and tag them with a few different things

2) Add a tagged journal entry block to a page and select more than one tag.

3) Save the block config

4) Edit the block config and try removing one of the tags

Tags: regression
Robert Lyon (robertl-9)
Changed in mahara:
importance: High → Critical
Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5566

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5567

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5566
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/6cfee3c6c1dcd6e65545a955d5627d1475fdf149
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 6cfee3c6c1dcd6e65545a955d5627d1475fdf149
Author: Robert Lyon <email address hidden>
Date: Wed Oct 21 15:30:57 2015 +1300

Bug 1508204: Can remove tagged blog options in modal

Stops the modal from being closed when clicking on the 'x' on the tag
options.

behatnotneeded: will add behat test is subpatch as there needs to be a
new step added

Change-Id: I8c1589fb708e654ca3200e1893ed25def19a5a3d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5595

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5595
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/961169e39d23e60b4a1ded395b01e0983dc44b12
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit 961169e39d23e60b4a1ded395b01e0983dc44b12
Author: Robert Lyon <email address hidden>
Date: Wed Oct 21 15:30:57 2015 +1300

Bug 1508204: Can remove tagged blog options in modal

Stops the modal from being closed when clicking on the 'x' on the tag
options.

behatnotneeded: will add behat test is subpatch as there needs to be a
new step added

Change-Id: I8c1589fb708e654ca3200e1893ed25def19a5a3d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6cfee3c6c1dcd6e65545a955d5627d1475fdf149)

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5567
Committed: https://git.mahara.org/mahara/mahara/commit/d9770f354c2555388ede85ba0e243e675c618897
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d9770f354c2555388ede85ba0e243e675c618897
Author: Robert Lyon <email address hidden>
Date: Wed Oct 21 16:19:24 2015 +1300

Bug 1508204: behat test for removing tagged journal

Change-Id: Ic864bdcb8e777dfc59b81488ada8b82bfae27e0a
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6316

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.