Mahara

Have dedicated language strings for switchbox labels

Bug #1508723 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells
Mahara 15.10.0
15.04
Won't Fix
High
Robert Lyon
16.04
Fix Released
High
Aaron Wells
Mahara 16.04.0

Bug Description

Due to Bug 1467252, it may be necessary in some languages to relabel the switchboxes so that they don't say a direct translation of "Yes/No" or "Off/On".

The problem is, the switchboxes currently use the strings 'yes', 'no', 'off', and 'on' from mahara.php, which are potentially used throughout Mahara and can't be safely changed.

The solution is to use dedicated language strings just for the switchboxes, so that they can be relabelled for brevity without affecting the rest of Mahara.

Aaron Wells (u-aaronw)
tags: added: pieforms switchbox translations
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5584

Revision history for this message
Aaron Wells (u-aaronw) wrote :

For example, the 'yes' and 'no' strings are also used in admin/groups/delete.php, where they label a pair of buttons.

It's less clear whether 'on', 'off', 'true', and 'false', are used anywhere else in Mahara.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5584
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ee0f2ed2abde4f7d019deb0f00772200e172589d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit ee0f2ed2abde4f7d019deb0f00772200e172589d
Author: Aaron Wells <email address hidden>
Date: Thu Oct 22 12:51:29 2015 +1300

Dedicated language strings for switchboxes

Bug 1508723. Allows translations to come up with workarounds
for the switchbox label size limit bug, without affecting
the rest of Mahara.

behatnotneeded: Covered by existing tests

Change-Id: I9dc3491add303ac40831f567ad5ec41be6c34be7

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5600

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5600
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/8633db201e8f369786b5e5dff6244e76c4dbf8a8
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit 8633db201e8f369786b5e5dff6244e76c4dbf8a8
Author: Aaron Wells <email address hidden>
Date: Thu Oct 22 12:51:29 2015 +1300

Dedicated language strings for switchboxes

Bug 1508723. Allows translations to come up with workarounds
for the switchbox label size limit bug, without affecting
the rest of Mahara.

behatnotneeded: Covered by existing tests

Change-Id: I9dc3491add303ac40831f567ad5ec41be6c34be7
(cherry picked from commit ee0f2ed2abde4f7d019deb0f00772200e172589d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5623

Revision history for this message
Aaron Wells (u-aaronw) wrote :

For anyone affected by this in Mahara 15.04, there is a patch for this for 15.04, and it seems to work: https://reviews.mahara.org/5623

However, we're not going to be backporting this into the standard 15.04 release, because it causes the lang strings used by all the switchboxes to be changed. And that means that if you were to do an upgrade that included this fix, but you didn't also upgrade your langpack (or the translators for your langpack hadn't translated these new strings) then suddenly all the switchboxes would be in English.

That's too big of a potential side effect for inclusion in a minor release, because minor releases are meant to be low-risk.

That said, if you are affected by this issue, and you're comfortable customizing your site, feel free to apply the patch to your own site. You will then also probably need to supply the translated strings via local/lang.

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.