Mahara

Comments with attachments but no description look broken on large screen

Bug #1512525 reported by Robert Lyon
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 16.04.0
15.10
Fix Released
Medium
Robert Lyon
Mahara 15.10.1

Bug Description

Problem here is the float for the attachments is not pushed to the right as there is no content for the description float so it has no solidity.

to fix I'll add a content::after to the description element to add a non-breaking space.

Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5651

Revision history for this message
Dean (deans) wrote :

When manually testing this I added a comment with no description and one attachment, the attachment displays correctly. I then added a second comment with a description and four attachments and then a third comment with four attachments. This caused the alignment to look a bit weird. (screen shot attached)

Revision history for this message
Aaron Wells (u-aaronw) wrote :

To replicate:

1. Create a page
2. Put a comment on the page that has one or more attachments, but has the TinyMCE text field blank.
3. Submit that comment

Expected result: The comment displays okay
Actual result: See Robert's screenshot. The "Attachments (3)" text overlaps over the date string.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5651
Committed: https://git.mahara.org/mahara/mahara/commit/ba6d2cba7c1661516653f94a881909a5c24b1e0c
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit ba6d2cba7c1661516653f94a881909a5c24b1e0c
Author: Robert Lyon <email address hidden>
Date: Tue Nov 3 12:46:21 2015 +1300

Bug 1512525: Empty comment description causes display brokenness

So I'm giving it some invisible content, eg a non-breaking space, so
that the floats position correctly.

Behatnotneeded: It is a visual issue

Change-Id: If9bd1f67868f612087c683b57a6527fca3122a3f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Hi Dean:

I wasn't able to replicate the display issue you had. With the patch in place, and creating comments with the same text & number of attachments as you, I didn't have any issues in Firefox or Chromium. See the attachment.

Is it a browser-specific thing?

Cheers,
Aaron

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5659

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5659
Committed: https://git.mahara.org/mahara/mahara/commit/5648eb16adbd78559057f681efe2dc34e8bbe8ec
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit 5648eb16adbd78559057f681efe2dc34e8bbe8ec
Author: Robert Lyon <email address hidden>
Date: Tue Nov 3 12:46:21 2015 +1300

Bug 1512525: Empty comment description causes display brokenness

So I'm giving it some invisible content, eg a non-breaking space, so
that the floats position correctly.

Behatnotneeded: It is a visual issue

Change-Id: If9bd1f67868f612087c683b57a6527fca3122a3f
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ba6d2cba7c1661516653f94a881909a5c24b1e0c)

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.