Mahara

Button groups on user profile page doesnt have any margin with the select box

Bug #1513274 reported by Liam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Liam
Mahara 16.04.0
15.10
Fix Released
Medium
Unassigned
Mahara 15.10.1

Bug Description

The button group overlaps the profile picture and touches the top of the select box when the screen is small (but not quite mobile size).

To see the page:
Find a user -> view the profile, at the top there should be 4 buttons ie. login as, request friendship etc... Those buttons overlap the profile picture and touch the select box.

See original description
Liam (liam-sharpe)
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5660

Liam (liam-sharpe)
Changed in mahara:
status: New → In Progress
Revision history for this message
Aaron Wells (u-aaronw) wrote : Re: Button groups on user profile page overlap select box

Hi Liam,

I wasn't able to replicate this issue, using FF and Chromium in mobile simulation mode. See screenshots.

Can you send a screenshot of what you're seeing? And is it specific to a mobile browser, not just a window size thing?

Cheers,
Aaron

Changed in mahara:
status: In Progress → Incomplete
importance: Undecided → Medium
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Even when I go real narrow, the filter doesn't overlap anything.

Liam (liam-sharpe)
summary: - Button groups on user profile page overlap select box
+ Button groups on user profile page doesnt have any margin with the
+ select box
description: updated
Liam (liam-sharpe)
description: updated
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Okay, in Chromium comparing before and after pics, I do see a difference, with the user icon overlapping the underlying horizontal rule, and not aligned correctly. That gets fixed by the patch.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Okay, I got some clarification from Liam. This doesn't look so bad in full-on responsive mini-mode. It's actually most evident when you've got a window that is about half the width of a big monitor. All the buttons are still visible, they're just bunched up together, and may be overlapping by a few pixels. And the user icon is sunk, relative to the user name.

I've attached another, screenshot demonstrating this.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5660
Committed: https://git.mahara.org/mahara/mahara/commit/505003c0fc9a9b4d2949c5d787f09fac44378a3e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 505003c0fc9a9b4d2949c5d787f09fac44378a3e
Author: Liam Sharpe <email address hidden>
Date: Thu Nov 5 14:05:48 2015 +1300

Stopped overlaping buttons on user page - Bug #1513274

behatnotneeded

Change-Id: I6f899441829fc62458b05e978e5f5e3ac23b4c8b

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5661

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5661
Committed: https://git.mahara.org/mahara/mahara/commit/a5068d5d9fc4b41a87e3ef8c47c828fde5122e8a
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit a5068d5d9fc4b41a87e3ef8c47c828fde5122e8a
Author: Liam Sharpe <email address hidden>
Date: Thu Nov 5 14:05:48 2015 +1300

Stopped overlaping buttons on user page - Bug #1513274

behatnotneeded

Change-Id: I6f899441829fc62458b05e978e5f5e3ac23b4c8b
(cherry picked from commit 505003c0fc9a9b4d2949c5d787f09fac44378a3e)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.