help icons don't work in modal windows

Bug #1514718 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
15.10
Fix Released
High
Unassigned

Bug Description

Mahara 15.10

$config->version = 2015092910;
$config->series = '15.10';
$config->release = '15.10.0';

Browser: Firefox 42

When adding an Authentication plugin to an institution, in the modal forms, the help icons generate javascript errors.

such as:

* node.nextSibling is null (coming from admin/users/addauthority.php)

once the above is fixed:
* elem is null (coming from js/MOchiKit/DOM.js)

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I couldn't replicate this issue with auth instances, because I don't see the auth instance config in a modal. I see it in a separate pop-up window. Are you seeing auth instance config in a modal Ghada?

However, I was able to replicate this issue with the block configuration modal. Not the specific JS error, but just being unable to use them.

To replicate:

1. Add a "Creative Commons" block to a page.
2. Try to click on one of the help icons.

Expected result: You see the help text
Actual result: The help icons cannot be clicked on!

After some fidgeting I found that there was a clickable zone for each icon, but it was very small, like a few pixels tall.

Changed in mahara:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :

Hi Aaron,

We created a custom theme that's using modal windows for the auth instance config.

But, I'm glad you could reproduce the issue.

Cheers,
Ghada

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5729

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5729
Committed: https://git.mahara.org/mahara/mahara/commit/32d56680eaa5136b93a2756ef9af80b4be0dc78e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 32d56680eaa5136b93a2756ef9af80b4be0dc78e
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 17:01:47 2015 +1300

Bug 1514718: Help icons and trouble with .form-group position relative

The help icons clickable area was being hidden. Removing the position
relative seems to fix the problem and not cause any other issues.

behatnotneeded

Change-Id: Ib0ae7368c52ebdb952ba147f03e25ec3e4301d02
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5755

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5755
Committed: https://git.mahara.org/mahara/mahara/commit/bb4b80c7db3fb8922d89d85e37cf5a9b5fe05af3
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit bb4b80c7db3fb8922d89d85e37cf5a9b5fe05af3
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 17:01:47 2015 +1300

Bug 1514718: Help icons and trouble with .form-group position relative

The help icons clickable area was being hidden. Removing the position
relative seems to fix the problem and not cause any other issues.

behatnotneeded

Change-Id: Ib0ae7368c52ebdb952ba147f03e25ec3e4301d02
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 32d56680eaa5136b93a2756ef9af80b4be0dc78e)

no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.