Ubuntu
webbrowser-app package

Cannot move a bookmark to bin

Bug #1515631 reported by Jean-Baptiste Lallement
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
Canonical System Image ww02-2016 "ota9"
webbrowser-app (Ubuntu)
Fix Released
High
Olivier Tilloy

Bug Description

current build number: 175
device name: krillin
channel: ubuntu-touch/rc-proposed/bq-aquaris.en

TEST CASE:
1. Bookmark a page
2. Tap on the burger menu, then favourites to display the list of bookmark
3. Swipe the bookmark to the right to reveal the bin
4. Tap on the bin

Actual Result
It doesn't delete the bookmark

Expected Result
The bookmark is removed from the list

Tags: bookmarks

Related branches

lp:~osomon/webbrowser-app/missing-import-statements-bookmark-views
PS Jenkins bot: Needs Fixing (continuous-integration)
Ugo Riboni (community): Approve
Diff: 925 lines (+331/-173)
13 files modified
src/app/webbrowser/BookmarksFoldersView.qml (+3/-0)
src/app/webbrowser/BookmarksView.qml (+2/-0)
src/app/webbrowser/BookmarksViewWide.qml (+2/-0)
src/app/webbrowser/SettingsPage.qml (+5/-5)
tests/unittests/qml/WebbrowserTestCase.qml (+55/-0)
tests/unittests/qml/tst_AddressBar.qml (+1/-7)
tests/unittests/qml/tst_BookmarksFoldersViewWide.qml (+15/-40)
tests/unittests/qml/tst_BookmarksView.qml (+114/-0)
tests/unittests/qml/tst_BookmarksViewWide.qml (+111/-0)
tests/unittests/qml/tst_HistoryViewWide.qml (+12/-42)
tests/unittests/qml/tst_NewTabViewWide.qml (+8/-33)
tests/unittests/qml/tst_SettingsPage.qml (+2/-38)
tests/unittests/qml/tst_TabsBar.qml (+1/-8)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Seeing the following error in the logs:

    file:///usr/share/webbrowser-app/webbrowser/BookmarksView.qml:53: ReferenceError: BookmarksModel is not defined

Changed in webbrowser-app (Ubuntu):
importance: Undecided → High
status: New → Triaged
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Bill Filler (bfiller)
milestone: none → backlog
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
status: Triaged → In Progress
Olivier Tilloy (osomon)
tags: added: bookmarks
Revision history for this message
AlainKnaff (kubuntu-misc) wrote :

The odd thing is, while it doesn't work from the bookmarks menu, it does work from the New Tab menu.

You access that by sliding up from the lower edge, and then tapping "+ New Tab"

Just posting this to help others, until a proper fix is released.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Indeed, it works from the new tab view. A fix is ready and should land next week.

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151126-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151126-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Olivier Tilloy ]
  * Add missing import statements, and add missing unit tests for
    BookmarksView.qml and BookmarksViewWide.qml. (LP: #1515631)
  * Code cleanup: remove unused include statements and forward
    declarations, and convert unnecessary include statements to forward
    declarations.
  * Make the drawer menu flickable so that all its actions can be
    accessed even on a small mobile screen in landscape orientation.
    (LP: #1513348)
  * Prevent click events from propagating through the expanded history
    view to the view below. (LP: #1518904)
  * Use the capture device display names instead of their unique ID.
    (LP: #1518931)

 -- Olivier Tilloy <email address hidden> Thu, 26 Nov 2015 13:42:25 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: backlog → ww02-2016
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.