pcs cluster setup hangs

Status changed to 'Confirmed' because the bug affects multiple users.

So, since I'm fixing:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580035
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580045
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640923

I created a merge proposal in upstream project:

https://github.com/ClusterLabs/pcs/pull/119

For this particular fix:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919

I'll wait for this upstream small change to be accepted so I can propose complete fix to Debian and provide a PPA to be used while Debian is fixed (and then Zesty, Yakkety and finally Xenial).

This particular fix was accepted by upstream:

commit c64ad9f24ddd671714a11933a2a0ff6d87df6492
Author: Rafael David Tinoco <email address hidden>
Date: Tue Dec 6 01:34:18 2016 +0000

    Fix: "find" should run only in specific directories

    Some users reported that running find over "/var/lib" for cleanup
    purposes can take too long depending on what you have installed.
    A particular example was having "lxcfs" fuse mounted in /var/lib.
    That can make the search for cluster leftovers to take quite some
    time, making user to believe the process has hang.

Cases:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580035
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580045
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640923
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919

Are all being fixed into this case.

Related Debian Bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847294

For the upstream (packaging) fix.

Now, I approved all series nomination (of this and the related bugs), please fix up the metadata accordingly.

For the uploads: I'm always kinda ick to upload a package introducing a delta from debian, but well...
What I don't like are the changelogs: you're barely saying what you did, just listing the name of the patches you added and related bugs. I'd like to see "Add patch <name> to fix <problem>. LP: #xxxxx". This tends to be particularly important for SRUs, where users actually go reading the changelogs to see what they are doing to their stable installation and figure whether the changes affects them.

In the xenial debdiff, you have an invalid Bug-Debian in 0007-Fix-IPv6-bind.patch.

Hello Mattia,

> For the uploads: I'm always kinda ick to upload a package introducing a delta from debian, but well...

Well, you gotta fix what you gotta fix =).

> What I don't like are the changelogs: you're barely saying what you did, just listing the name of the patches you added and related bugs. I'd like to see "Add patch <name> to fix <problem>. LP: #xxxxx". This tends to be particularly important for SRUs, where users actually go reading the changelogs to see what they are doing to their stable installation and figure whether the changes affects them.

I can definitely add more information if you would like. You can see that the patches are really well explained. Some maintainers prefer a specific format in changelog, some others. I usually use this one but I do agree it doesn't cause any harm to add more information.

> In the xenial debdiff, you have an invalid Bug-Debian in 0007-Fix-IPv6-bind.patch.

Tks for reviewing it, will upload a new one shortly.

I attached the debdiffs again with suggestions you made.

Per favore fatemi sapere se avete bisogno di qualcosa di diverso.

Thank you much for sponsoring/reviewing.

Cheers

Rafael Tinoco

Umh, why did you close the Debian bug?

btw, I'll handle this during the day; the patches look good.

All uploaded.
Thank you!

This bug was fixed in the package pcs - 0.9.155-1ubuntu1

---------------
pcs (0.9.155-1ubuntu1) zesty; urgency=medium

  * Patch d/p/0011-Find-on-specific-directories-only.patch (LP: #1640919)
    Cleaning files when destroying a cluster was taking too long in /var/lib.
    Specifying /var/lib/pacemaker for "finding" leftovers solves the issue.

 -- Rafael David Tinoco <email address hidden> Fri, 09 Dec 2016 03:33:30 +0000

Hello Jonathan, or anyone else affected,

Accepted pcs into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pcs/0.9.153-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Jonathan, or anyone else affected,

Accepted pcs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pcs/0.9.149-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

The version available in xenial-updates does fixes this issue. Evidence -> http://pastebin.ubuntu.com/23736947/

The version available in yakkety-update does fix this issue. Evidence -> http://pastebin.ubuntu.com/23737093/

For the record, this is the script used to setup a clean machine with pcs:

sudo apt-get -q update
sudo apt-get -q -y install pcs

# we make sure corosync and pacemaker are stopped
sudo systemctl stop pacemaker
sudo systemctl stop corosync

# we remove corosync.conf, otherwise pcs will refuse to write the config
sudo rm -f /etc/corosync/corosync.conf

# pcs will configure corosync to log under /var/log/cluster
test -d /var/log/cluster || sudo mkdir /var/log/cluster

echo -e "ubuntu\nubuntu" | sudo passwd hacluster
sudo systemctl restart pcsd.service
sleep 10
sudo pcs cluster auth "pcs" -u hacluster -p ubuntu --force --debug
sudo pcs cluster setup --debug --force --name pacemaker1 "pcs"

This bug was fixed in the package pcs - 0.9.149-1ubuntu1

---------------
pcs (0.9.149-1ubuntu1) xenial; urgency=medium

  * Patch d/p/0006-Replace-orderedhash.patch added by Debian (LP: #1580035)
    Orderedhash gem can't be used due to licensing issues.
    Dependency package orderedhash replaced by activesupport.
    The daemon was not functional in Xenial before this.
  * Patch d/p/0007-Fix-IPv6-bind.patch (LP: #1580045)
    The daemon was being initialized listening only for IPv6 protocol.
  * Patch d/p/0008-Find-on-specific-directories-only.patch (LP: #1640919)
    Cleaning files when destroying a cluster was taking too long in /var/lib.
    Specifying /var/lib/pacemaker for "finding" leftovers solves the issue.

 -- Rafael David Tinoco <email address hidden> Fri, 09 Dec 2016 03:07:25 +0000

The verification of the Stable Release Update for pcs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Brian, is there any reason to not push this SRU into yakkety-updates as well?, it went into xenial-updates first :\

This bug was fixed in the package pcs - 0.9.153-2ubuntu1

---------------
pcs (0.9.153-2ubuntu1) yakkety; urgency=medium

  * Patch d/p/0010-Find-on-specific-directories-only.patch (LP: #1640919)
    Cleaning files when destroying a cluster was taking too long in /var/lib.
    Specifying /var/lib/pacemaker for "finding" leftovers solves the issue.

 -- Rafael David Tinoco <email address hidden> Fri, 09 Dec 2016 03:40:55 +0000