SSH service should be hidden from Startup Applications too

Bug #1657909 reported by Jeremy Bícha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-keyring (Ubuntu)
Fix Released
Low
Unassigned
Trusty
Invalid
Low
Unassigned
Xenial
Invalid
Low
Unassigned
Yakkety
Invalid
Low
Unassigned

Bug Description

SRU Team
========
Wait to accept this. Showing the SSH service was apparently intentional and not just an oversight.
https://launchpad.net/ubuntu/+source/gnome-keyring/3.10.1-1ubuntu4.2

Impact
======
Ubuntu has for several years set NoDisplay=true for various services that use /etc/xdg/autostart so that users don't open Startup Applications and turn off a service that isn't really meant to be disabled that way

gnome-keyring has a patch to do this, but one service "SSH Key Agent" needs to be added to the patch.

Test Case
=========
Install the updated gnome-keyring package.
Open Startup Applications in Ubuntu (Unity) or Ubuntu GNOME
"SSH Key Agent" should not show up in the list.

Regression Potential
====================
Low. If someone *did* uncheck the box next to SSH in Startup Applications, it will now be a bit more tricky to re-enable that service.

rm ~/.local/share/autostart/gnome-keyring-ssh.desktop

Tags: xenial yakkety
Jeremy Bícha (jbicha)
Changed in gnome-keyring (Ubuntu Xenial):
importance: Undecided → Low
status: New → In Progress
Changed in gnome-keyring (Ubuntu Yakkety):
importance: Undecided → Low
status: New → In Progress
Changed in gnome-keyring (Ubuntu Trusty):
importance: Undecided → Low
status: New → Triaged
Jeremy Bícha (jbicha)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-keyring - 3.20.0-3ubuntu1

---------------
gnome-keyring (3.20.0-3ubuntu1) zesty; urgency=medium

  * Merge with Debian. Remaining changes:
    - debian/control.in:
      + Add Vcs-Bzr for Ubuntu.
    - debian/control, debian/*.install, debian/rules:
      + Install pkcs11 in its own binary.
    - debian/gnome-keyring.ubiquity, debian/rules:
      + Apply capabilities at the end of the ubiquity process to make sure new
        installs have gnome-keyring-daemon with cap_ipc_lock+ep.
    - debian/gnome-keyring.conf, debian/gnome-keyring-ssh.conf:
      + Provide upstart user session jobs.
    - debian/user/*, debian/*.override, debian/rules:
      + Install units to start gnome-keyring with systemd if the session
        is using it.
      + Disable XDG autostart when we're using upstart.
    - 04_nodisplay_autostart.patch:
      + Mark autostart files as NoDisplay=true.
    - 0001-Look-for-both-dlopen-and-dlsym-when-configuring.patch:
      + Fix finding dlopen and dlsym in the build, fixing FTBFS.
    - 0002-pam-Pass-the-correct-argc-to-gkr_pam_client_run_oper.patch:
      + Fix null pointer dereference when no password is supplied, e.g. in
        lightdm --test-mode.
    - 0001-Die-if-the-XDG-session-we-were-started-under-goes-aw.patch:
      + Cherry-pick upstream patch to track our login session and exit if
        that ends. This means that gnome-keyring gets cleaned up properly
        on logout under dbus-user-session.
  * Update 04_nodisplay_autostart.patch to hide SSH service too
    (LP: #1657909)

gnome-keyring (3.20.0-3) unstable; urgency=medium

  [ Jeremy Bicha ]
  * Enable parallel building and all hardening flags
  * Add debian/patches/05_skip-known-test-failures.patch:
    - Skip a few failing tests that have already been reported upstream.
      Before the switch from cdbs to dh, these tests still failed but did
      not fail the build and therefore were mostly unnoticed.
  * Explicitly Build-Depend on python for tests (Closes: #832852)

  [ Dmitry Shachnev ]
  * Depend on default-dbus-session-bus | dbus-session-bus instead of
    dbus-x11 (closes: #835885).

 -- Jeremy Bicha <email address hidden> Thu, 19 Jan 2017 20:04:08 -0500

Changed in gnome-keyring (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

Wait to accept this.

Changed in gnome-keyring (Ubuntu Xenial):
status: In Progress → Incomplete
Changed in gnome-keyring (Ubuntu Yakkety):
status: In Progress → Incomplete
Changed in gnome-keyring (Ubuntu Trusty):
status: Triaged → Incomplete
Jeremy Bícha (jbicha)
Changed in gnome-keyring (Ubuntu Yakkety):
status: Incomplete → Invalid
Changed in gnome-keyring (Ubuntu Xenial):
status: Incomplete → Invalid
Changed in gnome-keyring (Ubuntu Trusty):
status: Incomplete → Invalid
Revision history for this message
Jeremy Bícha (jbicha) wrote :

As discussed today in #ubuntu-desktop, the current behavior is intentional. There is no other easy graphical way to tell gnome-keyring not to act as ssh agent, which is a common use case.

https://irclogs.ubuntu.com/2017/02/08/%23ubuntu-desktop.html

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

After this I have gnome-keyring-daemon process showing up in system-monitor which is started by /usr/bin/gnome-keyring-daemon --daemonize --login and takes about 20mb instead of few kb. Is this the normal?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.