Mahara

Pages and collections search form 'searchtype' not being sticky

Bug #1679864 reported by Robert Lyon
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
Mahara 17.04.0
17.10
Fix Released
High
Unassigned
Mahara 17.10.0

Bug Description

Need to allow the searchtype to be sticky just like the orderby one

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.04.0
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Robert Lyon (robertl-9) wrote :

Also need to fix up the search to work correctly, the searchtype 'titleanddescriptiontags' is not working. The code for it is missing - need to adjust the views_by_owner() function so that we can differentiate between the three options

Changed in mahara:
importance: Medium → High
assignee: nobody → Robert Lyon (robertl-9)
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
assignee: Robert Lyon (robertl-9) → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7619

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Confirmed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7619
Committed: https://git.mahara.org/mahara/mahara/commit/94edbbdc13a30ed602cb9335ea5f085f69c5bec4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 94edbbdc13a30ed602cb9335ea5f085f69c5bec4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 11 15:03:57 2017 +1200

Bug 1679864: added third search option in p&c screen

 - user can search in tags, in title+decription
   or in title+description+tags
 - the last type of search user chooses will be remembered
 - fixed search for the other options
 - fixed bug when there are same number of collections
   and pages to display.

behatnotneeded

Change-Id: Ibd206d5ac211893b52b26b7be9582785cbad606e

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7669

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7669
Committed: https://git.mahara.org/mahara/mahara/commit/bf84b991e908759aead3f4eeaeb278d0d28c24b6
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit bf84b991e908759aead3f4eeaeb278d0d28c24b6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 11 15:03:57 2017 +1200

Bug 1679864: added third search option in p&c screen

 - user can search in tags, in title+decription
   or in title+description+tags
 - the last type of search user chooses will be remembered
 - fixed search for the other options
 - fixed bug when there are same number of collections
   and pages to display.

behatnotneeded

Change-Id: Ibd206d5ac211893b52b26b7be9582785cbad606e
(cherry picked from commit 94edbbdc13a30ed602cb9335ea5f085f69c5bec4)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.