Ubuntu
gnome-shell-extension-autohidetopbar package

[zesty] Hide Top Bar preferences dialog doesn't work

Bug #1683154 reported by Jeremy Bícha
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-shell-extension-autohidetopbar (Ubuntu)
Fix Released
Medium
Unassigned
Zesty
Fix Released
Undecided
Unassigned

Bug Description

Impact
------
GNOME 3.24 (used in Ubuntu 17.04) switched from mozjs24 to mozjs38. mozjs38 has stricter syntax requirements which means many extensions need to adapt.

The Hide Top Bar extension's Preferences dialog does not work and displays this error message:

TypeError: redeclaration of let settings_vbox

Stack trace:
  Application<._getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:74:13
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178:22
  Application<._selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:89:31
  wrapper@resource:///org/gnome/gjs/modules/lang.js:178:22
  Application<._extensionFound/<@resource:///org/gnome/shell/extensionPrefs/main.js:206:17
  main@resource:///org/gnome/shell/extensionPrefs/main.js:399:5
  @<main>:1:49

I had a few gnome-shell crashes with this extension enabled.
https://github.com/mlutfy/hidetopbar/issues/132 suggests that the same bug fix could fix that issue too.

Test Case
---------
From Ubuntu GNOME 17.04:
sudo apt install gnome-shell-extenaion-autohidetopbar
Log out and log back in.
Open Tweak Tool. Switch to the Extensions panel and enable Hide Top Bar.
Click the gear button next to Hide Top Bar. The preferences dialog should display without an error.

Regression Potential
--------------------
This obviously makes this package work a lot better.

See original description
Jeremy Bícha (jbicha)
description: updated
Revision history for this message
Andy Whitcroft (apw) wrote : Please test proposed package

Hello Jeremy, or anyone else affected,

Accepted gnome-shell-extension-autohidetopbar into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-autohidetopbar/20161203-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-shell-extension-autohidetopbar (Ubuntu Zesty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-autohidetopbar - 20161203-1ubuntu1

---------------
gnome-shell-extension-autohidetopbar (20161203-1ubuntu1) zesty; urgency=medium

  * Add gnome324-compat.patch:
    - Backport git commit to make compatible with GNOME 3.24 (LP: #1683154)

 -- Jeremy Bicha <email address hidden> Sun, 16 Apr 2017 11:14:09 -0400

Changed in gnome-shell-extension-autohidetopbar (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I installed gnome-shell-extension-autohidetopbar 20161203-1ubuntu1 on Ubuntu GNOME 17.04. After logging out and logging back in, I enabled the Hide Top Bar extension in Tweak Tool. I clicked the gear button to view the Preferences. GNOME Shell did not quickly crash like I experienced in some of my testing with the old version.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-autohidetopbar - 20161203-1ubuntu1

---------------
gnome-shell-extension-autohidetopbar (20161203-1ubuntu1) zesty; urgency=medium

  * Add gnome324-compat.patch:
    - Backport git commit to make compatible with GNOME 3.24 (LP: #1683154)

 -- Jeremy Bicha <email address hidden> Sun, 16 Apr 2017 11:14:09 -0400

Changed in gnome-shell-extension-autohidetopbar (Ubuntu Zesty):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-autohidetopbar has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.