Caja crashes when opening D/L folder from Firefox

Bug #1683653 reported by lauricat
124
This bug affects 22 people
Affects Status Importance Assigned to Milestone
caja (Ubuntu)
Fix Released
Medium
Unassigned
Zesty
Fix Released
Medium
Unassigned

Bug Description

[Impact]

Opening download folder from Firefox results in UI freeze for the whole session. Some keyboard shortcuts might still work, but mouse doesn't. Need to kill Firefox to unfreeze the system.

The patch attached to this report fixes the issue.

The fix is already present in Artful and tested by developers and users. Would be nice to backport it to Zesty as well, as the whole session freeze is quite a bad thing (even though you can stop it).

[Test Case]

Steps to reproduce:
- have a terminal running
- run Firefox
- download some file from somewhere
- click on download button to show the file list
- click on "open containing folder" button

Most UI apps will freeze after that. As Alt-Tab shortcut still works, use it to switch to terminal and run "killall firefox".

[Regression Potential]

None. The UI freeze *is* the regression. The patch restores the missing DBus interface initialization and affects nothing else.

[Other Info]

The patch is included into the debdiff attached to bug 1680604.

The debdiff contains patches to fix bug 1680604, bug 1683653, bug 1688687. See other reports for the corresponding SRU templates.

[Original Description]

Expected:

Using Firefox 52.02, when File download finishes, opening "Display the progress of ongoing Downloads" (arrow on Right of address bar), then selecting "Open Containing Folder" icon from Firefox opens Downloads folder on system.

What happens:

Using Firefox 52.02, when File download finishes, opening "Display the progress of ongoing Downloads" (arrow on Right of address bar), then selecting "Open Containing Folder" icon from Firefox, causes system to hang/crash for period of 2 minutes; (opening menu's, shutdown button, opening any program at all, etc). Sometimes only way to get response from system is shutdown/restart.

Steps to reproduce:

1. Start Ubuntu MATE 17.04.
2. Run Firefox.
3. Browse to any site.
4. Download a file from site.
5. Wait until Download arrow indicator next to address bar arrow on Firefox indicates a completed download.
6.Click on arrow next to/on right address bar "Display the progress of ongoing Downloads".
7. Click on icon "Open Containing Folder".
8. Computer will then freeze/hang/crash for a period of at least 2 minutes.

Additional notes:

1.Computer is unresponsive at this time, menu's are unresponsive, run application [ALT+ F2] unresponsive, Tabs on Firefox Browser unresponsive, any other programs running unresponsive, unable to close/open any programs.

1a. Note: This unresponsive period may last 2 minutes, or sometimes will only become responsive after killing Firefox process.

2.The date/time applet will still update however. Other applets unresponsive.

3. Terminal can be run [ALT+ CNRL+T].

4. Terminal will allow "pidof" to be run, to find PID of Firefox.

5. Firefox can be then "killed" by "kill [pid] xxx" via terminal. Computer becomes responsive again.

6. Running Ubuntu Mate 17.04 from a bootable USB results in the same thing/problem happening.

7.Same problem happens with Firefox Version 51.

8. Downgrade to 16.10 on same machine, no problem occurs.

9. No crash error report in "about:crashes" in Firefox built in diagnostics.

Computer Specs:

X220 Lenevo/i5/16GB RAM/250GB SSD

Thank-you.

(Please let me know if I have done any of this incorrectly or need any other information. First Bug report!)

~L.

lauricat (lauricat)
description: updated
description: updated
lauricat (lauricat)
description: updated
description: updated
description: updated
Revision history for this message
Mindaugas (ogis1975) wrote :

I have a same issue here on Ubuntu mate 17.04. When i want to open the "Download" location, Firefox freezes, but about 10 sec. or so, opening files, but not in file manager, but in Audacious music player....

Revision history for this message
Alexander Browne (elcste) wrote :

The same thing happens for me with Mozilla's build of Firefox Nightly version 55.0a1 (2017-04-18).

Revision history for this message
Bill_MI (bill-mi) wrote :

Also happens when displaying Firefox's Download History (Ctrl+Shft+Y) and triggered by the same "Open Containing Folder" icon.

no longer affects: ubuntu-mate
Changed in firefox (Ubuntu):
status: New → Confirmed
Revision history for this message
Etamuk (trmfach) wrote :

Today i tested Solus MATE 2017.04.18 with Mate Desktop 1.18.0.
There Firefox also freezes when trying to open "Downloads" after downloading a file.

Revision history for this message
Rocco (bigdaddylinux) wrote :

I am also affected by this as well.

Revision history for this message
nyarla33 (mr-somewhere) wrote :

There is a patch that corrects this bug:

https://github.com/mate-desktop/caja/commit/6ece67ffa2b3c90f4c0ae69147b62ea255da3636

https://github.com/mate-desktop/caja/issues/771

The issue was actually a regression from migrating Caja to GtkApplication in 1.18.

Revision history for this message
Chad Work (chadwork2001) wrote :

I have this problem with Ubuntu Mate 17.04 x64 kernel 4.10.0-20, Firefox 53.0 x64 as of 5/7/2017.

It was happening in Fedora as well, so then I switched to Ubuntu Mate thinking I'd get away from it but was wrong.

Revision history for this message
Chad Work (chadwork2001) wrote :

Can you folks who add solutions come down from outer space and tell us newbs how to do this in a language we can understand?

Seeing this:
      */
     G_APPLICATION_CLASS (caja_application_parent_class)->startup (app);

+ /* Start the File Manager DBus Interface */
+ fdb_manager = caja_freedesktop_dbus_new (app);
+
     /* Initialize preferences. This is needed so that proper
      * defaults are available before any preference peeking
      * happens.

Does not tell me how to fix it.

Revision history for this message
Matti Viljanen (direc85) wrote :

Confirming both that the issue exists and that the patch does the trick. Applying this patch file:

https://github.com/mate-desktop/caja/commit/6ece67ffa2b3c90f4c0ae69147b62ea255da3636.patch

as-is into the 1.18.1-0ubuntu2 source code (although offset is -4 rows) works - I just opened the Downloads folder from Firefox.

Right, I don't know if this is correct, but I'm going to switch the package affected to caja as it is the package that needs the patch, not Firefox... Please correct my actions when necessary.

Revision history for this message
Matti Viljanen (direc85) wrote :

Changing affected package from firefox to caja, as the regression is in caja.

affects: firefox (Ubuntu) → caja (Ubuntu)
Revision history for this message
Vlad Orlov (monsta) wrote :

This is now fixed upstream in Caja 1.18.3.

tags: added: zesty
Revision history for this message
yaztromo (tromo) wrote :

Will the fix for caja be released in Zesty? I keep accidentally freezing my system :)

If not, can anyone post some instructions on how to apply the fix please.

Revision history for this message
Vlad Orlov (monsta) wrote :

Well, it's up to the maintainers now.

Revision history for this message
yaztromo (tromo) wrote :

As far as I can tell, from the chatter on the Ubuntu Mate discussion forums, this fix likely won't make it in 17.04. Will have to wait till 17.10 for it, which is not all that far away.

Revision history for this message
awi (alefeltes) wrote :

I had notice this same behavior from Firefox running Ubuntu Mate 17.04, with a slightly different discover.
One time I did notice the freeze, got a call and left the computer for a while, later to see that the Downloads folder did opened, but after several seconds.
Following that first long wait, the "Open Containing folder" works normally.

Revision history for this message
Etienne Papegnies (etienne-papegnies) wrote :

@alefeltes yes, the freeze is temporary.

https://ubuntu-mate.community/t/firefox-freezes-after-trying-to-open-downloads/12630

See here the Ubuntu MATE forum thread on the subject.

Revision history for this message
Vlad Orlov (monsta) wrote :

An updated patch, which also fixes a build warning introduced in the original patch.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "restore DBus interface initialization" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
summary: - Ubuntu MATE 17.04 crashes when opening D/L folder from Firefox
+ Caja crashes when opening D/L folder from Firefox
Changed in caja (Ubuntu):
status: Confirmed → Fix Released
Vlad Orlov (monsta)
tags: added: ubuntu-mate-zesty-sru
Changed in caja (Ubuntu Zesty):
status: New → Triaged
Changed in caja (Ubuntu):
importance: Undecided → Medium
Changed in caja (Ubuntu Zesty):
importance: Undecided → Medium
Revision history for this message
Vlad Orlov (monsta) wrote :

[Impact]

Opening download folder from Firefox results in
UI freeze for the whole session. Some keyboard
shortcuts might still work, but mouse doesn't.
Need to kill Firefox to unfreeze the system.

The patch attached to this report fixes the issue.

The fix is already present in Artful and tested by
developers and users. Would be nice to backport it
to Zesty as well, as the whole session freeze is
quite a bad thing (even though you can stop it).

[Test Case]

Steps to reproduce:
- have a terminal running
- run Firefox
- download some file from somewhere
- click on download button to show the file list
- click on "open containing folder" button

Most UI apps will freeze after that.
As Alt-Tab shortcut still works, use it to switch
to terminal and run "killall firefox".

[Regression Potential]

None. The UI freeze *is* the regression. The patch
restores the missing DBus interface initialization
and affects nothing else.

[Other Info]

The patch is included into the debdiff attached to
bug 1680604.

The debdiff contains patches to fix bug 1680604,
bug 1683653, bug 1688687. See other reports for the
corresponding SRU templates.

Simon Quigley (tsimonq2)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello lauricat, or anyone else affected,

Accepted caja into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/caja/1.18.1-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in caja (Ubuntu Zesty):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-zesty
Revision history for this message
ldmpub (ldmpub) wrote :

Hi,

I'm affected by this bug under Xubuntu 16.04 LTS / i686. How can I install and test this fix?

Thanks in advance for your answer.

Revision history for this message
Vlad Orlov (monsta) wrote :

There's no official MATE 1.18 release for Xenial. If you're using some unofficial third-party repository, ask its maintainer to update Caja to 1.18.3.

Revision history for this message
Vlad Orlov (monsta) wrote :

Testing in Zesty. It's done after testing the fix for bug 1680604, so the packages are already updated to version 1.18.1-0ubuntu2.1 from zesty-proposed.

This test is simple... I just downloaded a file via Firefox and clicked on the button to open the download folder. The folder is opened in Caja as intended. There are no UI freezes.

For the record, the file to download was just upstream Caja tarball:
http://pub.mate-desktop.org/releases/1.18/caja-1.18.4.tar.xz

Vlad Orlov (monsta)
tags: added: verification-done verification-done-zesty
removed: verification-needed verification-needed-zesty
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package caja - 1.18.1-0ubuntu2.1

---------------
caja (1.18.1-0ubuntu2.1) zesty; urgency=medium

  * Added patches:
    + fix-list-view-zoom.patch - fixes visual issues with zoom in
      list view (LP: #1680604)
    + restore-dbus-init.patch - restores DBus initialization to fix
      Firefox freeze when opening download folder (LP: #1683653)
    + fix-mousewheel-scroll.patch - fixes mousewheel scrolling over
      pathbar buttons (LP: #1688687)

 -- Vlad Orlov <email address hidden> Mon, 06 Nov 2017 22:00:31 +0300

Changed in caja (Ubuntu Zesty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for caja has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.