Mahara

Allow the pressing of 'enter' button to do search in Admin -> User search form

Bug #1687494 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 17.04.1
17.04
Fix Released
Low
Robert Lyon
Mahara 17.04.1
17.10
Fix Released
Low
Robert Lyon
Mahara 17.10.0

Bug Description

Currently the Admin -> User search form is not a true html form but is controlled via javascript.

And so we can search by clicking the 'Search' button but we can't search by hitting enter on our keyboard while focused in the search field.

I'll add some code to allow this also.

Will mark as low priority as one can still search

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7710

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.10
no longer affects: mahara/15.04
no longer affects: mahara/15.10
no longer affects: mahara/16.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7710
Committed: https://git.mahara.org/mahara/mahara/commit/0c9f2ff8d791e69ae8b8d22141dafa8352108412
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0c9f2ff8d791e69ae8b8d22141dafa8352108412
Author: Robert Lyon <email address hidden>
Date: Tue May 2 10:40:41 2017 +1200

Bug 1687494: Allow enter key to submit Admin -> User search form

So make it function like the 'Search' button

behatnotneeded

Change-Id: Idebac8be4c87e0138415ce22b16b2dcc2b1d7dc4
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7746

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7746
Committed: https://git.mahara.org/mahara/mahara/commit/4c11fc1f0a583bfc2d5a01af95cbcad1eca6bfe7
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 4c11fc1f0a583bfc2d5a01af95cbcad1eca6bfe7
Author: Robert Lyon <email address hidden>
Date: Tue May 2 10:40:41 2017 +1200

Bug 1687494: Allow enter key to submit Admin -> User search form

So make it function like the 'Search' button

behatnotneeded

Change-Id: Idebac8be4c87e0138415ce22b16b2dcc2b1d7dc4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0c9f2ff8d791e69ae8b8d22141dafa8352108412)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.