Mahara

Webservices logs page broken due to missing institution value

Bug #1708545 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 17.10.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.5
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.3
17.10
Fix Released
Medium
Robert Lyon
Mahara 17.10.0

Bug Description

If an external service tries to access webservices with bad token it can mean logging of error before the institution value is known meaning no institution is set in external_services_logs table.

So when the Webservices -> Logs page tries to display the logs it fails as it can't fetch institution name of 'null'.

So we need to fix this so that it displays a placeholder string instead

Revision history for this message
Robert Lyon (robertl-9) wrote :

This is also due to switching the db table to accepting null as institution so only affects 16.10+

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7917

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7917
Committed: https://git.mahara.org/mahara/mahara/commit/2b3f239de1f4e19019ba1fda2fa77a8a3f6857de
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2b3f239de1f4e19019ba1fda2fa77a8a3f6857de
Author: Robert Lyon <email address hidden>
Date: Fri Aug 4 10:15:09 2017 +1200

Bug 1708545: Allow placeholder for institution column if not known

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7931

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7932

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7932
Committed: https://git.mahara.org/mahara/mahara/commit/b359ff78ae57872817081550014941a8d774191d
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit b359ff78ae57872817081550014941a8d774191d
Author: Robert Lyon <email address hidden>
Date: Fri Aug 4 10:15:09 2017 +1200

Bug 1708545: Allow placeholder for institution column if not known

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2b3f239de1f4e19019ba1fda2fa77a8a3f6857de)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7931
Committed: https://git.mahara.org/mahara/mahara/commit/d1aca37c4f3dcec8c26b4e3d10ff4faa8eaa5e3a
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit d1aca37c4f3dcec8c26b4e3d10ff4faa8eaa5e3a
Author: Robert Lyon <email address hidden>
Date: Fri Aug 4 10:15:09 2017 +1200

Bug 1708545: Allow placeholder for institution column if not known

So that the Webservice -> Logs page will display things

Also fixed broken lang string

behatnotneeded

Change-Id: If73210e0b2f8986ddd84db4cf3f9d40dcc50565b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2b3f239de1f4e19019ba1fda2fa77a8a3f6857de)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.