fanctl does not exit with an error when an up step fails
Bug #1719644 reported by
Stefan Bader
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-fan (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Stefan Bader | ||
Zesty |
Fix Released
|
Medium
|
Stefan Bader | ||
Artful |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
SRU Justification:
Impact:
When running cmd_up there are a few failure points which call fail_up to unwind but then do not exit with failure. This also has effect on running "fanatic enable-fan" which itself runs fanctl.
Fix:
Force the fail_up function to do a hard stop by adding an "exit 1" statement.
Testcase:
[fan is installed but not enabled]
- sudo flock -x /run/xtables.lock sleep 300
- fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?
Changed in ubuntu-fan (Ubuntu Xenial): | |
assignee: | nobody → Stefan Bader (smb) |
importance: | Undecided → Medium |
status: | New → Fix Committed |
Changed in ubuntu-fan (Ubuntu Zesty): | |
assignee: | nobody → Stefan Bader (smb) |
importance: | Undecided → Medium |
status: | New → Fix Committed |
Changed in ubuntu-fan (Ubuntu): | |
assignee: | Stefan Bader (smb) → nobody |
tags: | added: verification-needed verification-needed-zesty |
To post a comment you must log in.
This bug was fixed in the package ubuntu-fan - 0.12.6
---------------
ubuntu-fan (0.12.6) artful; urgency=medium
* fanatic: Add short success delay to nc_send (LP: #1721352)
* fanatic: Catch test preparation steps failing (LP: #1718548)
* fanatic: Add DNS checks to local-test preparation (LP: #1718548)
ubuntu-fan (0.12.5) artful; urgency=medium
* DEP8: Fix LXD default interface detection (LP: #1718548)
* fanctl: return error on fail_up (LP: #1719644)
-- Stefan Bader <email address hidden> Fri, 06 Oct 2017 12:15:38 +0200