Mahara

Remove unnecessary steps from behat tests

Bug #1732297 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Rebecca Blundell
Mahara 18.04.0

Bug Description

In a lot of cases, there are repeated and unnecessary steps being done in tests. For instance, a test that has nothing to do with logging in will have:

    Given I log in as "admin" with password "Kupuhipa1"
    # Verifying log in was successful
    And I should see "Admin User"

We don't need to check the login works every time.
Also, there are a lot of cases where we could add a new page in the background (i.e, it is not a manual add page test) and instead it is done manually in a collection of steps.

Fixing these things should improve performance.

Tags: behat
Rebecca Blundell (rjb-dev)
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8280

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: Undecided → Medium
milestone: none → 18.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8280
Committed: https://git.mahara.org/mahara/mahara/commit/a323c8d83406835131362ca9b700e4a80e26922e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a323c8d83406835131362ca9b700e4a80e26922e
Author: Rebecca Blundell <email address hidden>
Date: Wed Nov 15 16:02:01 2017 +1300

Bug 1732297: Remove unnessesary steps from tests

Done:
Removed checks that user name is visible after login unless it's
related to what's being tested.
where possible added pages in background instead of manually
deleted character_limit, forgot_password and create_group as content was covered in other tests.
checked for other unnessesary "And I should see/ not see" steps
fixed stuff I broke

Change-Id: Ideaff604e49c6ca4b369bf96a3377e38d680d77d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.