cherry-pick https://codereview.qt-project.org/#/c/224684/ to fix image slideshows in KDE Plasma

This has been uploaded to Bionic.

Yay, thanks!

This has migrated.

This fix was not in Qt 5.9.5. Re-opening.

This bug was fixed in the package qtdeclarative-opensource-src - 5.11.1-4

---------------
qtdeclarative-opensource-src (5.11.1-4) unstable; urgency=medium

  * Update symbols files with buildds' logs.

 -- Lisandro Damián Nicanor Pérez Meyer <email address hidden> Thu, 26 Jul 2018 22:09:16 -0300

That's for 5.11.1; what about the backport to 5.9.5 for Bionic?

Am I missing something? There is nothing to fix in qtdeclarative-opensource-src for Cosmic since it has Qt 5.11, and Qt 5.11 simply includes the fix by default.

This bug tracks cherry-picking the fix into the version of qtdeclarative-opensource-src that's in Bionic.

You are right. The bug was fixed upstream in 5.11 so I marked the Cosmic task as fixed. For Bionic, I opened a new task and it is not fixed.

Thank you!

Any chance you can update the bug description as required by the Stable Release Update procedure?

https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Thanks a lot, I will upload the fix for 5.9 tomorrow.

Thanks so much Dmitry!

Uploaded, here it is in the review queue: https://launchpad.net/ubuntu/bionic/+queue?queue_state=1.

Fantastic, thanks so much!

Hello Nate, or anyone else affected,

Accepted qtdeclarative-opensource-src into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/5.9.5-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Thanks! I enabled the bionic-proposed repo and saw the package update available yesterday, but had no time available to do the update and perform tests. Now I do, but I no longer see an update to qtdeclarative-opensource-src available--just qtdeclarative5-dev and qtdeclarative5-qtquick2-plugin. Was it already accepted?

qtdeclarative-opensource-src is a source package name, it builds multiple binary packages — you can see a list of them here: https://packages.ubuntu.com/bionic/source/qtdeclarative-opensource-src.

In this case the relevant binary package is probably libqt5quick5, but it is better to upgrade all these packages together.

Thanks for bearing with me.

I can confirm that the fix works after installing the relevant packages. I tested it by setting a slideshow wallpaper with a change interval of one second. Before the fix, this would cause plasmashell's memory usage to skyrocket. With the fix applied, the memory usage is stable.

The verification of the Stable Release Update for qtdeclarative-opensource-src has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package qtdeclarative-opensource-src - 5.9.5-0ubuntu1.1

---------------
qtdeclarative-opensource-src (5.9.5-0ubuntu1.1) bionic; urgency=medium

  * Cherry-pick upstream patch to fix memory leak in image slideshows in
    KDE Plasma (LP: #1761016).

 -- Dmitry Shachnev <email address hidden> Sun, 26 Aug 2018 14:32:09 +0300

Thanks everyone!