Ubuntu
gnome-shell-extension-system-monitor package

gio.settings errors after lockscreen

Bug #1786608 reported by Jamie Strandboge
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-system-monitor (Debian)
Fix Released
Unknown
gnome-shell-extension-system-monitor (Ubuntu)
Fix Released
High
Jamie Strandboge
Bionic
Fix Released
High
Jamie Strandboge
Cosmic
Fix Released
High
Jamie Strandboge

Bug Description

This is https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/issues/449.

[Impact]
When the gnome-shell-extension-system-monitor is enabled, after the user's session is locked then unlocked, then gnome-shell starts profusely logging errors of this sort:

Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: == Stack trace for context 0x556916f3c320 ==
Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: #0 0x5569172eba10 i /<email address hidden>/extension.js:2009 (0x7fcadae3db38 @ 39)
Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: #1 0x7ffcee147f70 b resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7fcb140b5de0 @ 71)
Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: #2 0x7ffcee148760 b /<email address hidden>/extension.js:928 (0x7fcb02dac340 @ 70)
Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: #3 0x7ffcee148820 b resource:///org/gnome/gjs/modules/_legacy.js:82 (0x7fcb140b5de0 @ 71)
Aug 09 17:34:44 localhost org.gnome.Shell.desktop[16993]: #4 0x7ffcee1488d0 b self-hosted:913 (0x7fcb140f12b8 @ 346)
Aug 09 17:34:45 localhost gnome-shell[16993]: Object Gio.Settings (0x55692427b520), has been already deallocated - impossible to access to it. This might be caused by the fact that the object has been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs

This will quickly fill the logs to the limits of what journald allows (4G here) and make observing the log difficult in general (since the log entries come in at the frequency of enabled monitors of the extension).

[Test Case]

1. apt-get install gnome-shell-extension-system-monitor
2. enable the extension in gnome-tweaks
3. lock the screen, wait a few seconds, then log back in
4. observe in journalctl --follow the stack traces for the extension. If you disable the extension, the logging stops. Sometimes it takes a couple of minutes for the log spamming to start after logging back in

When testing the fix, it is important that after upgrading to the new version, you logout of your session then back in. Disabling/enabling the extension does not seem to be enough.

[Regression Potential]

Regression potential is considered low since the patch simply moves the initialization code into the enable() function (gnome-shell appears to disable the extension on lock, and enable on unlock).

See original description
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Uploaded to cosmic.

Changed in gnome-shell-extension-system-monitor (Ubuntu Bionic):
status: New → Triaged
assignee: nobody → Jamie Strandboge (jdstrand)
Changed in gnome-shell-extension-system-monitor (Ubuntu Cosmic):
assignee: nobody → Jamie Strandboge (jdstrand)
Changed in gnome-shell-extension-system-monitor (Ubuntu Bionic):
importance: Undecided → High
Changed in gnome-shell-extension-system-monitor (Ubuntu Cosmic):
importance: Undecided → High
status: New → Triaged
status: Triaged → In Progress
status: In Progress → Fix Committed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Uploaded to bionic-proposed.

Changed in gnome-shell-extension-system-monitor (Ubuntu Bionic):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-system-monitor - 35-1ubuntu1

---------------
gnome-shell-extension-system-monitor (35-1ubuntu1) cosmic; urgency=medium

  * debian/patches/fix-object-gio.settings-has-already-been-deallocated.patch:
    Move initialization to enable(), and then properly disable() some objects.
    - LP: #1786608

 -- Jamie Strandboge <email address hidden> Fri, 10 Aug 2018 21:15:37 +0000

Changed in gnome-shell-extension-system-monitor (Ubuntu Cosmic):
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gnome-shell-extension-system-monitor (Debian):
status: Unknown → New
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Seeing that upstream isn't really much active nowadays, not blocking on this getting approved upstream. Accepting.

Changed in gnome-shell-extension-system-monitor (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Jamie, or anyone else affected,

Accepted gnome-shell-extension-system-monitor into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-system-monitor/35-1ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

To be clear, the patch is from upstream master.

Jamie Strandboge (jdstrand)
description: updated
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

35-1ubuntu0.18.04.1 fixes the issue.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ah indeed, missed the mention that it's fixed in master. Anyway, all good.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-system-monitor - 35-1ubuntu0.18.04.1

---------------
gnome-shell-extension-system-monitor (35-1ubuntu0.18.04.1) bionic-proposed; urgency=medium

  * debian/patches/fix-object-gio.settings-has-already-been-deallocated.patch:
    Move initialization to enable(), and then properly disable() some objects.
    - LP: #1786608

 -- Jamie Strandboge <email address hidden> Sat, 11 Aug 2018 07:04:39 -0500

Changed in gnome-shell-extension-system-monitor (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-system-monitor has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Bug Watch Updater (bug-watch-updater)
Changed in gnome-shell-extension-system-monitor (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.