lshw does not list NVMe storage devices as "disk" nodes

Ref: https://github.com/lyonel/lshw/pull/45/commits/16e1d7b9e9a1aa69a59867de0aad6411c953fbfc

I don't recall posting this bug that I don't think is a bug. NVM is not a disk so why should it be reported as a disk?

@Stephane, I am open to it.

Here are all class current supported:

    system, bridge, memory, processor, address, storage, disk, tape,
    bus, network, display, input, printer, multimedia, communication,
    power, volume, generic

Per quick check, NVME / SATA controller are belongs to storage class.
Agree NVME is not a 'disk' becuase nothing spins, however it probably
the best place it goes given current on hwNode only have one class.

Maybe https://www.intel.com/content/www/us/en/products/memory-storage/optane-dc-persistent-memory.html is something really harder to decide whether we should put it in memory or storage.

@Yuan - Thank you.

For precedent in this issue can we look to the transition from tape to disk? Both are devices for persistent storage but each is in its own class. Now with NVM we have a third type of storage device so perhaps we should consider a new class.

lshw is a hardware listing. Classifying NVM as 'disk' is a metaphor. So the question is how far are we comfortable introducing or extending metaphor into a hardware listing? Can we live with that loss of precision?

hmm, per check https://github.com/lyonel/lshw/pull/45https://github.com/lyonel/lshw/pull/45/commits/16e1d7b9e9a1aa69a59867de0aad6411c953fbfc/commits/16e1d7b9e9a1aa69a59867de0aad6411c953fbfc

it belongs to both storage and disk class.

This shows as 'nothing to compare'.

Of course it is your decision to make and your effort for which we are grateful. Thank you.

However I want to go on record as protesting. An NVME storage device is a disk only so far as it is a tape.

Status changed to 'Confirmed' because the bug affects multiple users.

The attachment "lshw-hirsute.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

Has this been corrected?

in Ubuntu 20.10.

[code]
shw -c storage
...
  *-storage
       description: Non-Volatile memory controller
       product: NVMe SSD Controller SM951/PM951
...
[/code]

The initial report suggests that NVME SSD should appear as 'disk' This would not be correct since NVME SSDs are not disks they are chips providing storage.

What am I missing?

[sts-sponsors][hirsute]

I have reported a bug against debian/lshw:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977774

We could add the NVME support via cherrypick in active development release (hirsute) as proposed by my colleague Victor, but I would rather prefer to see lshw to bump version from B.02.18 to B.02.19 so that hirsute will be updated (take the opportunity that Hirsute is in development release to do the necessary to save us time later when Hirsute will become stable)

https://ezix.org/project/wiki/HardwareLiSter#Changes

To do so Debian has to accept the bump, and I'll then do a sync or merge from debian/unstable to ubuntu/Hirsute.

Let's see if Debian is reactive to my request, and I'll adjust accordingly.

In order of preference:
1) If Debian is reactive in a timely fashion to my request, I'll wait for them to bump the package and then merge/sync into Ubuntu.
2) If Debian takes time to answer to my request, I'll sponsor Victor's patchset as is.

But I do think it's worth putting this on hold a couple of days and wait for a possible outcome for scenario #1.

- Eric

[sts-sponsors[hirsute]

In the absence of a reply from Debian, I have sponsored the patchset in Hirsute.

My preference would have been to have a version bump but nevertheless, the request to bump the version is still opened, and it's not too late for us to sync with Debian once done if this still fit with the current Hirsute freeze schedule: (or worse case scenario for next active devel release)

https://discourse.ubuntu.com/t/hirsute-hippo-release-schedule/18539

- Eric

This bug was fixed in the package lshw - 02.18.85-0.5ubuntu2

---------------
lshw (02.18.85-0.5ubuntu2) hirsute; urgency=medium

  * Add cherry-picked patches for NMVe support (LP: #1826737):
    - d/p/lp1826737-code-clean-up.patch
    - d/p/lp1826737-implement-NVMe-scanning.patch
    - d/p/lp1826737-align-physical-ID-with-NVMe-namespace.patch
    - d/p/lp1826737-treat-NVMe-namespaces-like-disks.patch

 -- Victor Manuel Tapia King <email address hidden> Thu, 17 Dec 2020 10:34:41 +0100

[sts-sponsors][groovy][focal][bionic]

Sponsored.

Thanks for your contribution Victor.

Hello Stephen, or anyone else affected,

Accepted lshw into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lshw/02.18.85-0.3ubuntu2.20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Stephen, or anyone else affected,

Accepted lshw into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lshw/02.18.85-0.3ubuntu2.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Stephen, or anyone else affected,

Accepted lshw into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lshw/02.18-0.1ubuntu6.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Installed and ran the application. Although output for device is correct there is another issue.

lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 20.10
Release: 20.10
Codename: groovy

As below

lshw-B.02.18$ lshw
WARNING: you should run this program as super-user.
terminate called after throwing an instance of 'std::length_error'
  what(): cannot create std::vector larger than max_size()
Aborted (core dumped)
~/projects/lshw-B.02.18$ su
Password:
root@asus:/home/stephen/projects/lshw-B.02.18# lshw -class disk
root@asus:/home/stephen/projects/lshw-B.02.18# lshw -class storage
  *-storage
       description: SATA controller
       product: HM170/QM170 Chipset SATA Controller [AHCI Mode]
       vendor: Intel Corporation
       physical id: 17
       bus info: pci@0000:00:17.0
       version: 31
       width: 32 bits
       clock: 66MHz
       capabilities: storage msi pm ahci_1.0 bus_master cap_list
       configuration: driver=ahci latency=0
       resources: irq:128 memory:dd430000-dd431fff memory:dd434000-dd4340ff ioport:f090(size=8) ioport:f080(size=4) ioport:f060(size=32) memory:dd433000-dd4337ff
  *-storage
       description: Non-Volatile memory controller
       product: NVMe SSD Controller SM951/PM951
       vendor: Samsung Electronics Co Ltd
       physical id: 0
       bus info: pci@0000:3d:00.0
       version: 01
       width: 64 bits
       clock: 33MHz
       capabilities: storage pm msi pciexpress msix nvm_express bus_master cap_list
       configuration: driver=nvme latency=0
       resources: irq:16 memory:dd100000-dd103fff ioport:d000(size=256)
root@asus:/home/stephen/projects/lshw-B.02.18# lshw | grep -C5 -i nvme
             capabilities: pci pciexpress msi pm normal_decode bus_master cap_list
             configuration: driver=pcieport
             resources: irq:126 ioport:d000(size=4096) memory:dd100000-dd1fffff
           *-storage
                description: Non-Volatile memory controller
                product: NVMe SSD Controller SM951/PM951
                vendor: Samsung Electronics Co Ltd
                physical id: 0
                bus info: pci@0000:3d:00.0
                version: 01
                width: 64 bits
                clock: 33MHz
                capabilities: storage pm msi pciexpress msix nvm_express bus_master cap_list
                configuration: driver=nvme latency=0
                resources: irq:16 memory:dd100000-dd103fff ioport:d000(size=256)
        *-isa
             description: ISA bridge
             product: HM170 Chipset LPC/eSPI Controller
             vendor: Intel Corporation

Hi Stephen,

I haven't been able to reproduce the issue you are seeing. Is this happening with the version in -proposed (02.18.85-0.3ubuntu2.20.10.1)? Would you mind attaching the generated core dump to this bug so I can take a look at it?

I can't reproduce neither on container nor baremetal.

In addition to Victor, can you tell us on what type of platform it was run ? (baremetal, VM, container (priv/unpriv), ... ) ?

- Eric

https://en.cppreference.com/w/cpp/error/exception/what

Pointer to a null-terminated string with explanatory information. The pointer is guaranteed to be valid at least until the exception object from which it is obtained is destroyed, or until a non-const member function on the exception object is called.

The way I see your outputs, is that you only get the error when performing: lshw ?

If it is the case, could you also run 'lshw' with super privileges for each class and report which one is coredumping ? That might help isolate the situation to a given class, and narrow down the situation.

Classes can be found using 'lshw -short'

- Eric

lshw -version
unknown
the latest version is B.02.18

'dpkg -i | grep -i lshw' will provide the version. We just want to confirm you were using the package found in groovy-proposed.

It will be useful for Victor to download the right debug symbol.

At first glance, your lshw binary doesn't seem to come from our package.

We ship the binary in /usr/bin, and your crash indicates:
ExecutablePath: /usr/sbin/lshw

root@gtest:~# lsb_release -cs
groovy

root@gtest:~# dpkg -l | grep -i lshw
ii lshw 02.18.85-0.3ubuntu2.20.10.1 amd64 information about hardware configuration

root@gtest:~# dpkg -L lshw
/.
/usr
/usr/bin
/usr/bin/lshw
/usr/share
/usr/share/doc
/usr/share/doc/lshw
/usr/share/doc/lshw/changelog.Debian.gz
/usr/share/doc/lshw/copyright
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/lshw.1.gz

My guess is that you have more than one 'lshw' on your system such as a compiled version (/usr/sbin) of 'lshw' and our Ubuntu package (/usr/bin), and when you are executing 'lshw' it calls the compiled one and not the one coming from our package.

You can confirm it by doing :

dpkg -S /usr/bin/lshw # It should report "lshw: /usr/bin/lshw" which is our package
dpkg -S /usr/sbin/lshw # It should report "dpkg-query: no path found matching pattern /usr/sbin/lshw"

In that case, just make sure you call /usr/bin/lshw directly and test again.

$ echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

/usr/sbin is before /usr/bin, hence why it is called first.

If I copy lshw from /usr/bin into /usr/sbin

$ which lshw
/usr/sbin/lshw

so that would make sense (until I'm proven wrong). In that case, as said above, you aren't calling the binary from our proposed package (even if likely installed)

Yes. I had built from the source. lshw-B.02.18 and then lshw-02.18.85.

I had enabled proposed but it had no effect. Perhaps I had downloaded too early?

Anyway, after updating and trying as you suggest /usr/bin/lshw then everything works as expected.

I hope this error did not cause too much unnecessary effort.

No worries, glad we figured it out.

# VERIFICATION GROOVY

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.10
DISTRIB_CODENAME=groovy
DISTRIB_DESCRIPTION="Ubuntu 20.10"

$ apt-cache policy lshw
lshw:
  Installed: 02.18.85-0.3ubuntu2.20.10.1
  Candidate: 02.18.85-0.3ubuntu2.20.10.1
  Version table:
 *** 02.18.85-0.3ubuntu2.20.10.1 500
        500 http://archive.ubuntu.com/ubuntu groovy-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     02.18.85-0.3ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu groovy/main amd64 Packages

$ sudo lshw -short -c storage,disk
H/W path Device Class Description
========================================================
/0/100/1 /dev/fb0 storage QEMU NVM Express Controller
/0/100/1/0 /dev/nvme0 storage QEMU NVMe Ctrl
/0/100/1/0/1 /dev/nvme0n1 disk 10GB NVMe namespace
/0/100/5 storage Virtio block device
/0/100/5/0 /dev/vda disk 32GB Virtual I/O device
/0/100/1f.2 storage 82801IR/IO/IH (ICH9R/DO/DH) 6 port SATA Controller [AHCI mode]

Long output: https://pastebin.ubuntu.com/p/jXcqZM4JQQ/

# VERIFICATION FOCAL

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.1 LTS"

$ apt-cache policy lshw
lshw:
  Installed: 02.18.85-0.3ubuntu2.20.04.1
  Candidate: 02.18.85-0.3ubuntu2.20.04.1
  Version table:
 *** 02.18.85-0.3ubuntu2.20.04.1 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     02.18.85-0.3ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

$ sudo lshw -short -c storage,disk
H/W path Device Class Description
========================================================
/0/100/1 /dev/fb0 storage QEMU NVM Express Controller
/0/100/1/0 /dev/nvme0 storage QEMU NVMe Ctrl
/0/100/1/0/1 /dev/nvme0n1 disk 10GB NVMe namespace
/0/100/5 storage Virtio block device
/0/100/5/0 /dev/vda disk 32GB Virtual I/O device
/0/100/1f.2 storage 82801IR/IO/IH (ICH9R/DO/DH) 6 port SATA Controller [AHCI mode]

Long output: https://pastebin.ubuntu.com/p/xGSbbVWw23/

# VERIFICATION BIONIC

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.04
DISTRIB_CODENAME=bionic
DISTRIB_DESCRIPTION="Ubuntu 18.04.5 LTS"

$ apt-cache policy lshw
lshw:
  Installed: 02.18-0.1ubuntu6.18.04.2
  Candidate: 02.18-0.1ubuntu6.18.04.2
  Version table:
 *** 02.18-0.1ubuntu6.18.04.2 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     02.18-0.1ubuntu6.18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     02.18-0.1ubuntu6 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

$ sudo lshw -short -c storage,disk
H/W path Device Class Description
====================================================
/0/100/1.1 storage 82371SB PIIX3 IDE [Natoma/Triton II]
/0/100/5 storage Virtio block device
/0/100/5/0 /dev/vda disk 32GB Virtual I/O device
/0/100/7 storage QEMU NVM Express Controller
/0/100/7/0 /dev/nvme0 storage QEMU NVMe Ctrl
/0/100/7/0/1 /dev/nvme0n1 disk 10GB NVMe namespace

Long output: https://pastebin.ubuntu.com/p/bk2Q8JJxzS/

This bug was fixed in the package lshw - 02.18.85-0.3ubuntu2.20.10.1

---------------
lshw (02.18.85-0.3ubuntu2.20.10.1) groovy; urgency=medium

  * Add cherry-picked patches for NMVe support (LP: #1826737):
    - d/p/lp1826737-code-clean-up.patch
    - d/p/lp1826737-implement-NVMe-scanning.patch
    - d/p/lp1826737-align-physical-ID-with-NVMe-namespace.patch
    - d/p/lp1826737-treat-NVMe-namespaces-like-disks.patch

 -- Victor Manuel Tapia King <email address hidden> Thu, 17 Dec 2020 10:34:41 +0100

The verification of the Stable Release Update for lshw has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package lshw - 02.18.85-0.3ubuntu2.20.04.1

---------------
lshw (02.18.85-0.3ubuntu2.20.04.1) focal; urgency=medium

  * Add cherry-picked patches for NMVe support (LP: #1826737):
    - d/p/lp1826737-code-clean-up.patch
    - d/p/lp1826737-implement-NVMe-scanning.patch
    - d/p/lp1826737-align-physical-ID-with-NVMe-namespace.patch
    - d/p/lp1826737-treat-NVMe-namespaces-like-disks.patch

 -- Victor Manuel Tapia King <email address hidden> Thu, 17 Dec 2020 10:34:41 +0100

This bug was fixed in the package lshw - 02.18-0.1ubuntu6.18.04.2

---------------
lshw (02.18-0.1ubuntu6.18.04.2) bionic; urgency=medium

  * Backported patches for NMVe support (LP: #1826737):
    - d/p/lp1826737-code-clean-up.patch
    - d/p/lp1826737-implement-NVMe-scanning.patch
    - d/p/lp1826737-align-physical-ID-with-NVMe-namespace.patch
    - d/p/lp1826737-treat-NVMe-namespaces-like-disks.patch

 -- Victor Manuel Tapia King <email address hidden> Thu, 17 Dec 2020 10:34:41 +0100