installing zsys breaks desktop login

Bug #1850052 reported by Alan Pope 🍺🐧🐱 🦄
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zsys (Ubuntu)
Fix Released
High
Didier Roche-Tolomelli
Eoan
Fix Released
High
Didier Roche-Tolomelli

Bug Description

[Impact]
After installing zsys on 19.10, you can't log in in your desktop. Removing it won't fix the issue.

[Test Case]
Test A: (migrating broken people)
1. Install 19.10 using experimental ZFS disk partitioning and reboot on installed system.
2. sudo apt install zsys
3. Reboot
4. Attempt to login to the desktop
-> you can't log in.
5. Go to a tty (ctrl + alt + F3) and log in as your user
6. Install zsys 0.2.3 from -proposed
7. Reboot
-> you can now log in in GDM.

Test B: (direct installation)
1. Install 19.10 using experimental ZFS disk partitioning and reboot on installed system.
2. Install zsys from proposed
3. Reboot
-> you can log in in GDM.

[Regression Potential]
Due to a missing rename in the installer from "org.zsys" to "com.ubuntu.zsys", we added transitional code which can be dropped in 20.04 as soon as compatible ubiquity is installed. People in 19.10 up to date (with the SRU fix) will have the required compatible tag.
Note that we only due to transition once, the first time we are able to set the current timestamp.
This doesn't regress any existing tests. Note that as this is due to unsync behavior between installer and zsys, zsys is behaving as expecting (unfortunately to the user) and the transitional code being removed soon, we didn't add a special test which will be removed later on.

-----

I installed zsys on an up to date 19.10 system and can now no longer login. Removing zsys from a tty does not solve the problem.
The home partition is no longer available - I have "lost" all my files, which were there before I installed zsys and rebooted

Steps to reproduce.

1. Install 19.10 using experimental ZFS disk partitioning.
2. Complete the first run wizard
3. Install all updates
4. sudo apt install zsys
5. reboot
6. Attempt to login to the desktop

Actual outcome

* GDM accepts user/password, clears screen, looks like desktop is about to start, then I get dropped back to GDM

Expected outcome

* Login successful.

ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: zsys 0.2.2
ProcVersionSignature: Ubuntu 5.3.0-19.20-generic 5.3.1
Uname: Linux 5.3.0-19-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu8
Architecture: amd64
Date: Sun Oct 27 14:50:10 2019
InstallationDate: Installed on 2019-10-27 (0 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
SourcePackage: zsys
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :
description: updated
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Worth noting after installing zsys and logging in via a tty, my files are "missing" and my home directory is owned by root:root. This is probably what's causing the inability to login, as session files can't be created.

Looks like zsys broke the mounting of the pool used by my home folder.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in zsys (Ubuntu):
status: New → Confirmed
Revision history for this message
Łukasz Piekarski (roypen7) wrote :

It looks like login with Wayland "works" but home folder is missing. I've tried purge zsys from the system but it didn't change anything.

description: updated
Changed in zsys (Ubuntu Eoan):
importance: Undecided → High
Changed in zsys (Ubuntu):
importance: Undecided → High
Changed in zsys (Ubuntu Eoan):
status: New → Triaged
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Tested zsys from the ubuntu-desktop ppa on a clean system which has not had zsys installed. I am able to login and see my files.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

(Uploaded to focal-proposed)

Changed in zsys (Ubuntu):
status: Confirmed → Fix Committed
Changed in zsys (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Piekarski (roypen7) wrote :

Sorry, I made a mistake changing the status. to Fix Released.
I've installed ppa on clean Ubuntu system and I can log in without any problems.

Changed in zsys (Ubuntu):
status: Fix Released → Fix Committed
Changed in zsys (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
Changed in zsys (Ubuntu Eoan):
assignee: nobody → Didier Roche (didrocks)
Revision history for this message
Chris Halse Rogers (raof) wrote :

Hello didrocks, or anyone else affected,

Accepted zsys into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zsys/0.2.2+19.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-eoan
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (zsys/0.2.2+19.04)

All autopkgtests for the newly accepted zsys (0.2.2+19.04) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

zsys/0.2.2+19.04 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#zsys

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zsys - 0.2.4

---------------
zsys (0.2.4) focal; urgency=medium

  * Skip tests on platform we don't build a binary for
    (no grub2-common package available).
    Autopkgtests will still try to run it if it ever ran one day
    and would fail as it can't install zsys.

zsys (0.2.3) focal; urgency=medium

  * Backward compatibility for org.zsys set on user datasets and transition
    to newer com.ubuntu.zsys (LP: #1850052)

 -- Didier Roche <email address hidden> Tue, 29 Oct 2019 07:48:55 +0100

Changed in zsys (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

zsys/0.2.2 autopkgtests were already failing, so not a regression.

Confirming that installing zsys from -proposed fix the 2 previous use cases.

tags: added: verification-done-eoan
removed: verification-needed-eoan
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, as discussed on IRC, I conditionally approve of this getting released early due to the bug causing login issues. But just in case, let's keep our eyes out for any regressions caused by this upload in other bits of zsys in the nearest days.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zsys - 0.2.2+19.04

---------------
zsys (0.2.2+19.04) eoan; urgency=medium

  * Backward compatibility for org.zsys set on user datasets and transition
    to newer com.ubuntu.zsys (LP: #1850052)

 -- Didier Roche <email address hidden> Mon, 28 Oct 2019 09:51:38 +0100

Changed in zsys (Ubuntu Eoan):
status: Triaged → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for zsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Thanks everyone for the prompt fix!
Love you all.
<3

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.