udev has truncated ID_SERIAL value for scsi disk

Fairly sure the problem is this line from https://git.launchpad.net/ubuntu/+source/sg3-utils/tree/scripts/55-scsi-sg3_id.rules?h=applied/1.44-1ubuntu1#n48:

ENV{ID_SERIAL}!="?*", ENV{SCSI_IDENT_LUN_NAA_EXT}=="?*", ENV{ID_BUS}="scsi", ENV{ID_SERIAL}="3$env{SCSI_IDENT_LUN_NAA}", ENV{ID_SERIAL_SHORT}="$env{SCSI_IDENT_LUN_NAA_EXT}"

(the variable being checked for and used are different). This appears to be fixed in a recent upstream commit https://github.com/hreinecke/sg3_utils/commit/c4c6af020963d11b624da6abb53f792074f943b2#diff-20e0363765997dae20aaceb68ba039e3 that contains a whole bunch of other stuff. Cherry-picking just that fix would presumably help (and then the patch can be removed when next upstream release is uploaded).

FWIW, this buggy rule is present in bionic too, but I guess it doesn't fire for some reason -- I guess SCSI_IDENT_LUN_NAA_EXT isn't being emitted for some reason, but I haven't actually checked.

That sounds like a good fix. It will trip in bionic, but ubuntu images don't include multipath package by default (which pulls in sg3-utils). If you install this in bionic, I suspect it will fail just the same.

This bug was fixed in the package sg3-utils - 1.44-1ubuntu2

---------------
sg3-utils (1.44-1ubuntu2) focal; urgency=medium

  * Fix a typo in a udev rule that leads to truncated ID_SERIAL values in
    udev. (LP: #1859858)

 -- Michael Hudson-Doyle <email address hidden> Tue, 25 Feb 2020 11:00:07 +1300

Verified that the fix in focal works, have now uploaded it to bionic and eoan proposed.

> It's possible some users have inadvertently depended on the serial being the same for all disks but it seems very unlikely.

I think it's also possible some users are relying on the serial number of some disk somehow, and that's about to change. But on balance I think this is acceptable, since we're fixing the serial number value to the correct one, and it's the same dilemma as users relying on any other bug.

Hello Ryan, or anyone else affected,

Accepted sg3-utils into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sg3-utils/1.42-2ubuntu1.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ryan, or anyone else affected,

Accepted sg3-utils into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sg3-utils/1.44-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Verified on eoan:

m@m:~$ dpkg -l sg3-utils-udev
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-=============-============-=============================================================
ii sg3-utils-udev 1.44-1ubuntu1 all utilities for devices using the SCSI command set (udev rules)
m@m:~$ udevadm info --query=property /dev/sdb | grep ID_SERIAL=
ID_SERIAL=3
m@m:~$ sudo apt install sg3-utils-udev/eoan-proposed
[elided]
m@m:~$ sudo udevadm trigger /dev/sdb
m@m:~$ dpkg -l sg3-utils-udev
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-===============-============-=============================================================
ii sg3-utils-udev 1.44-1ubuntu1.1 all utilities for devices using the SCSI command set (udev rules)
m@m:~$ udevadm info --query=property /dev/sdb | grep ID_SERIAL=
ID_SERIAL=322dc58dc023c7008

And bionic:

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=====================================-=======================-=======================-================================================================================
ii sg3-utils-udev 1.42-2ubuntu1.18.04.1 all utilities for devices using the SCSI command set (udev rules)
m@m:~$ udevadm info --query=property /dev/sdb | grep ID_SERIAL
ID_SERIAL=3
ID_SERIAL_SHORT=22dc58dc023c7008
m@m:~$ sudo apt install sg3-utils-udev/bionic-proposed
Reading package lists... Done
Building dependency tree
Reading state information... Done
Selected version '1.42-2ubuntu1.18.04.2' (Ubuntu:18.04/bionic-proposed [all]) for 'sg3-utils-udev'
The following packages will be upgraded:
  sg3-utils-udev
1 upgraded, 0 newly installed, 0 to remove and 65 not upgraded.
Need to get 5,112 B of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://nz.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 sg3-utils-udev all 1.42-2ubuntu1.18.04.2 [5,112 B]
Fetched 5,112 B in 0s (27.8 kB/s)
(Reading database ... 67172 files and directories currently installed.)
Preparing to unpack .../sg3-utils-udev_1.42-2ubuntu1.18.04.2_all.deb ...
Unpacking sg3-utils-udev (1.42-2ubuntu1.18.04.2) over (1.42-2ubuntu1.18.04.1) ...
Setting up sg3-utils-udev (1.42-2ubuntu1.18.04.2) ...
update-initramfs: deferring update (trigger activated)
Processing triggers for initramfs-tools (0.130ubuntu3.8) ...
update-initramfs: Generating /boot/initrd.img-4.15.0-88-generic
m@m:~$ sudo udevadm trigger /dev/sdb
m@m:~$ dpkg -l sg3-utils-udev
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-=====================================-=======================-=======================-================================================================================
ii sg3-utils-udev 1.42-2ubuntu1.18.04.2 all utilities for devices using the SCSI command set (udev rules)
m@m:~$ udevadm info --query=property /dev/sdb | grep ID_SERIAL
ID_SERIAL=322dc58dc023c7008
ID_SERIAL_SHORT=22dc58dc023c7008

This bug was fixed in the package sg3-utils - 1.42-2ubuntu1.18.04.2

---------------
sg3-utils (1.42-2ubuntu1.18.04.2) bionic; urgency=medium

  * Fix a typo in a udev rule that leads to truncated ID_SERIAL values in
    udev. (LP: #1859858)

 -- Michael Hudson-Doyle <email address hidden> Tue, 10 Mar 2020 14:05:18 +1300

The verification of the Stable Release Update for sg3-utils has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package sg3-utils - 1.44-1ubuntu1.1

---------------
sg3-utils (1.44-1ubuntu1.1) eoan; urgency=medium

  * Fix a typo in a udev rule that leads to truncated ID_SERIAL values in
    udev. (LP: #1859858)

 -- Michael Hudson-Doyle <email address hidden> Tue, 25 Feb 2020 11:00:07 +1300