[SRU] test_null_byte_char test failure

Bug #1861124 reported by Corey Bryant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pandas (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
High
Unassigned
Eoan
Fix Released
High
Unassigned

Bug Description

[Description]
When fixing LP: #1861148, test_null_byte_char was also failing. This has been fixed upstream via https://github.com/pandas-dev/pandas/commit/fec26028f66dd4854ff852857e33495a51d4445a. This patch allows for more flexible handling of the msg text from the csv.Error exception that comes from Python itself in Modules/_csv.c.

[Test Case]
A successful build of the package verifies this fix.

[Regression Potential]
Very low. This is already fixed upstream and in Ubuntu Focal. The code that is being patched is within an 'except csv.Error' path so only affects code that is handling that exact error. The code is making handling of that error more flexible when detecting the message string.

description: updated
summary: - test_null_byte_char test is failing on bionic
+ [SRU] test_null_byte_char test is failure
summary: - [SRU] test_null_byte_char test is failure
+ [SRU] test_null_byte_char test failure
Changed in pandas (Ubuntu):
status: New → Fix Released
description: updated
Changed in pandas (Ubuntu Bionic):
status: New → Triaged
Changed in pandas (Ubuntu Eoan):
status: New → Triaged
Changed in pandas (Ubuntu Bionic):
importance: Undecided → High
Changed in pandas (Ubuntu Eoan):
importance: Undecided → High
description: updated
description: updated
description: updated
Revision history for this message
Corey Bryant (corey.bryant) wrote :
Revision history for this message
Robie Basak (racb) wrote :

Accepting, thanks. As part of SRU verification please smoke test to ensure that the amd64 build hasn't regressed due to some unrelated issue.

Changed in pandas (Ubuntu Eoan):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-eoan
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Corey, or anyone else affected,

Accepted pandas into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pandas/0.23.3+dfsg-4ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in pandas (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Robie Basak (racb) wrote :

Hello Corey, or anyone else affected,

Accepted pandas into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pandas/0.22.0-4ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Robie Basak (racb) wrote :

As Eoan is currently correctly built for armhf, this fix can be held in eoan-proposed. Bionic should be released after verifying since there is a fix needed for Eoan users on armhf here.

tags: added: block-proposed-eoan
Revision history for this message
Corey Bryant (corey.bryant) wrote :

pandas 0.22.0-4ubuntu1 built successfully for all architectures for bionic

Revision history for this message
Corey Bryant (corey.bryant) wrote :

pandas 0.23.3+dfsg-4ubuntu1.1 built successfully for all architectures for eoan

Revision history for this message
Corey Bryant (corey.bryant) wrote :

OpenStack smoke testing was successful on bionic-proposed:
======
Totals
======
Ran: 92 tests in 1008.2061 sec.
 - Passed: 84
 - Skipped: 8
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 460.2551 sec.

And OpenStack smoke testing was successful on eoan-proposed:
======
Totals
======
Ran: 92 tests in 1225.0830 sec.
 - Passed: 84
 - Skipped: 8
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 562.6837 sec.

tags: added: verification-done verification-done-bionic verification-done-eoan
removed: verification-needed verification-needed-bionic verification-needed-eoan
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pandas - 0.22.0-4ubuntu1

---------------
pandas (0.22.0-4ubuntu1) bionic; urgency=medium

  * d/p/mark_tests_working_on_intel_armhf.patch: Backport additional patch
    updates from Ubuntu Eoan package to enable successful armhf build
    (LP: #1861148).
  * d/p/troubleshoot-CI-29294.patch: Partial cherry-pick from upstream master
    that fixes test_null_byte_char failure (LP: #1861124).

 -- Corey Bryant <email address hidden> Tue, 28 Jan 2020 08:55:02 -0500

Changed in pandas (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for pandas has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pandas - 0.23.3+dfsg-4ubuntu1.1

---------------
pandas (0.23.3+dfsg-4ubuntu1.1) eoan; urgency=medium

  * d/p/troubleshoot-CI-29294.patch: Partial cherry-pick from upstream master
    that fixes test_null_byte_char failure (LP: #1861124).

 -- Corey Bryant <email address hidden> Tue, 28 Jan 2020 10:30:44 -0500

Changed in pandas (Ubuntu Eoan):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.