Ubuntu
sbuild-launchpad-chroot package

Update to version 0.17

Bug #1905634 reported by dann frazier
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sbuild-launchpad-chroot (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
dann frazier
Focal
Fix Released
Undecided
dann frazier

Bug Description

[Impact]
Currently sbuild-launchpad-chroot fails to build/run in bionic because of bug 1892879, where a backport of ubuntu-dev-tools to bionic accidentally dropped the python2 bindings this package uses. Since this package has been collaterally damaged for months, I propose that we use the same justification used for bug 1892879 and go ahead and update s-b-c to a newer upstream that works with the python3 bindings. Specifically, I suggest we backport the version from groovy to focal and bionic. (The version in hirsute has only non-functional differences that would require extra backporting).

Other than moving to python3 (which required minimal changes), all other changes to the source are fixes that have already been SRU'd back to bionic (bug 1872163, bug 1852677, bug 1858458), except for the addition of Vcs tags to debian/control.

[Test Case]
Test out all 3 commands on all supported releases:
for rel in xenial bionic focal groovy hirsute; do
  sbuild-launchpad-chroot create -n ${rel} -s ${rel} -a $(dpkg --print-architecture)
  sbuild-launchpad-chroot update -n ${rel}
  sbuild-launchpad-chroot remove -n ${rel}
done

[Where Problems May Occur]
For focal, the only diff ends up being to the changelog because all fixes from groovy have already been backported to focal. But we need to bump the version so that it will be > the bionic version.

For bionic, it's possible there are some different behaviors in the underlying python2/python3 behavior that could cause an unexpected difference. I did check that downloading via proxy still works fine - but perhaps there are other such issues I didn't think to check.

See original description
dann frazier (dannf)
Changed in sbuild-launchpad-chroot (Ubuntu):
status: New → Fix Released
Changed in sbuild-launchpad-chroot (Ubuntu Bionic):
status: New → In Progress
Changed in sbuild-launchpad-chroot (Ubuntu Focal):
status: New → In Progress
assignee: nobody → dann frazier (dannf)
Changed in sbuild-launchpad-chroot (Ubuntu Bionic):
assignee: nobody → dann frazier (dannf)
dann frazier (dannf)
description: updated
dann frazier (dannf)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

I was curious about whether or not this was still necessary as bug 1892879 has been resolved now. However, one still needs to manually install python-ubuntutools to be able to test sbuild-launchpad-chroot and then it still fails.

bdmurray@clean-bionic-amd64:~$ sudo sbuild-launchpad-chroot create -n bionic -s bionic -a $(dpkg --print-architecture)
[bionic] Creating config
Traceback (most recent call last):
  File "/usr/bin/sbuild-launchpad-chroot", line 376, in <module>
    args.func(args)
  File "/usr/bin/sbuild-launchpad-chroot", line 67, in create_chroot
    host_arch = host_architecture()
  File "/usr/lib/python2.7/dist-packages/ubuntutools/misc.py", line 96, in host_architecture
    encoding='utf-8').strip()
  File "/usr/lib/python2.7/subprocess.py", line 216, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'encoding'

So this SRU is still necessary.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello dann, or anyone else affected,

Accepted sbuild-launchpad-chroot into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sbuild-launchpad-chroot/0.17ubuntu0.20.10.1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sbuild-launchpad-chroot (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello dann, or anyone else affected,

Accepted sbuild-launchpad-chroot into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sbuild-launchpad-chroot/0.17ubuntu0.20.10.1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sbuild-launchpad-chroot (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
dann frazier (dannf) wrote :
Download full text (376.3 KiB)

Verification follows; TLDR, test case passed in each release.

dannf@lakitu:~$ cat test.sh
#!/bin/sh

set -e

for release in groovy focal bionic; do
    lxc launch ubuntu:${release} dannf-slc-${release}
    sleep 5 # give time for networking to come up
    lxc exec dannf-slc-${release} -- apt-add-repository ppa:dannf/dannf -y
    lxc exec dannf-slc-${release} -- apt install -y dannf
    lxc exec dannf-slc-${release} -- dannf-enable-proposed.sh
    lxc exec dannf-slc-${release} -- apt install -y sbuild-launchpad-chroot
    # LP: #1905634 Test Case
    for rel in xenial bionic focal groovy hirsute; do
 lxc exec dannf-slc-${release} -- \
     sbuild-launchpad-chroot create -n ${rel} -s ${rel} \
       -a $(dpkg --print-architecture)
 lxc exec dannf-slc-${release} -- \
     sbuild-launchpad-chroot update -n ${rel}
 lxc exec dannf-slc-${release} -- \
     sbuild-launchpad-chroot remove -n ${rel}
    done
    lxc stop dannf-slc-${release}
    lxc delete dannf-slc-${release}
done
dannf@lakitu:~$ ./test.sh
Creating dannf-slc-groovy
Starting dannf-slc-groovy
Repository: 'deb http://ppa.launchpad.net/dannf/dannf/ubuntu/ groovy main'
More info: https://launchpad.net/~dannf/+archive/ubuntu/dannf
Adding repository.
Adding deb entry to /etc/apt/sources.list.d/dannf-ubuntu-dannf-groovy.list
Adding disabled deb-src entry to /etc/apt/sources.list.d/dannf-ubuntu-dannf-groovy.list
Adding key to /etc/apt/trusted.gpg.d/dannf-ubuntu-dannf.gpg with fingerprint 1C4582E5CDE936B785D7C969D255A4056A8519FA
Get:1 http://security.ubuntu.com/ubuntu groovy-security InRelease [110 kB]
Get:2 http://ppa.launchpad.net/dannf/dannf/ubuntu groovy InRelease [17.5 kB]
Hit:3 http://archive.ubuntu.com/ubuntu groovy InRelease
Get:4 http://security.ubuntu.com/ubuntu groovy-security/main amd64 Packages [166 kB]
Get:5 http://archive.ubuntu.com/ubuntu groovy-updates InRelease [110 kB]
Get:6 http://security.ubuntu.com/ubuntu groovy-security/main amd64 c-n-f Metadata [2724 B]
Get:7 http://security.ubuntu.com/ubuntu groovy-security/restricted amd64 Packages [64.6 kB]
Get:8 http://security.ubuntu.com/ubuntu groovy-security/restricted Translation-en [10.1 kB]
Get:9 http://security.ubuntu.com/ubuntu groovy-security/restricted amd64 c-n-f Metadata [380 B]
Get:10 http://security.ubuntu.com/ubuntu groovy-security/universe amd64 Packages [44.2 kB]
Get:11 http://security.ubuntu.com/ubuntu groovy-security/universe Translation-en [19.2 kB]
Get:12 http://security.ubuntu.com/ubuntu groovy-security/universe amd64 c-n-f Metadata [2092 B]
Get:13 http://security.ubuntu.com/ubuntu groovy-security/multiverse amd64 Packages [1272 B]
Get:14 http://security.ubuntu.com/ubuntu groovy-security/multiverse Translation-en [352 B]
Get:15 http://security.ubuntu.com/ubuntu groovy-security/multiverse amd64 c-n-f Metadata [116 B]
Get:16 http://archive.ubuntu.com/ubuntu groovy-backports InRelease [101 kB]
Get:17 http://archive.ubuntu.com/ubuntu groovy/universe amd64 Packages [12.6 MB]
Get:18 http://ppa.launchpad.net/dannf/dannf/ubuntu groovy/main amd64 Packages [444 B]
Get:19 http://ppa.launchpad.net/dannf/dannf/ubuntu groovy/main Translation-en [168 B]
Get:20 http://archive.ubuntu.com/ubuntu groovy...

tags: added: verification-done verification-done-bionic verification-done-focal
removed: verification-needed verification-needed-bionic verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild-launchpad-chroot - 0.17ubuntu0.20.10.1~20.04.1

---------------
sbuild-launchpad-chroot (0.17ubuntu0.20.10.1~20.04.1) focal; urgency=medium

  * Backport to focal. (LP: #1905634)

sbuild-launchpad-chroot (0.17ubuntu0.20.10.1) groovy; urgency=medium

  * Add direct (Build-)Dependency on python3-ubuntutools instead of
    relying on the indirect dependency via ubuntu-dev-tools.
    (LP: #1852677)

 -- dann frazier <email address hidden> Wed, 25 Nov 2020 17:06:49 -0700

Changed in sbuild-launchpad-chroot (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for sbuild-launchpad-chroot has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild-launchpad-chroot - 0.17ubuntu0.20.10.1~18.04.1

---------------
sbuild-launchpad-chroot (0.17ubuntu0.20.10.1~18.04.1) bionic; urgency=medium

  * Backport to bionic. (LP: #1905634)

sbuild-launchpad-chroot (0.17ubuntu0.20.10.1) groovy; urgency=medium

  * Add direct (Build-)Dependency on python3-ubuntutools instead of
    relying on the indirect dependency via ubuntu-dev-tools.
    (LP: #1852677)

 -- dann frazier <email address hidden> Wed, 25 Nov 2020 17:07:26 -0700

Changed in sbuild-launchpad-chroot (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.