`disk-image` not granular enough, often builds unused artifacts

Bug #1961760 reported by Ivan Kapelyukhin
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Ivan Kapelyukhin
Bionic
Fix Released
Undecided
Ivan Kapelyukhin
Focal
Fix Released
Undecided
Ivan Kapelyukhin
Impish
Fix Released
Undecided
Ivan Kapelyukhin

Bug Description

[Impact]

 * Due to how `disk-image` series file in `ubuntu-cpc` is structured, it builds BIOS and UEFI images at the same time. However, certain images (e.g., GCE images) require only UEFI image to be built, BIOS image is being simply discarded. This results in longer build times.

[Test Plan]

 * Build any image that depends on `disk-image` (e.g. a GCE image) with `livefs-build` or `ubuntu-bartender`
 * Read build logs and observe what build artifacts are produced: `disk.ext4` is the BIOS image and `disk-uefi.ext4` is the UEFI image

[Where problems could occur]

 * Due to changes in the `disk-images` series file the order in which BIOS and UEFI image are built has changed, if there's something sensitive to the order in which those artifacts are built it might break

[Other Info]

 * CPC images will be switched from `disk-image` to `disk-image-uefi` once the update is released

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.759

---------------
livecd-rootfs (2.759) jammy; urgency=medium

  * Optionally (when ALLOW_CORE_SNAP env var is set) allow to install core
    snap. Still needed by some CPC projects. (LP: #1964303)

 -- Thomas Bechtold <email address hidden> Fri, 04 Mar 2022 14:00:16 +0100

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Changed in livecd-rootfs (Ubuntu):
assignee: nobody → Ivan Kapelyukhin (ikapelyukhin)
Changed in livecd-rootfs (Ubuntu Bionic):
assignee: nobody → Ivan Kapelyukhin (ikapelyukhin)
Changed in livecd-rootfs (Ubuntu Focal):
assignee: nobody → Ivan Kapelyukhin (ikapelyukhin)
Changed in livecd-rootfs (Ubuntu Impish):
assignee: nobody → Ivan Kapelyukhin (ikapelyukhin)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Ivan, or anyone else affected,

Accepted livecd-rootfs into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.742.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Impish):
status: New → Fix Committed
tags: added: verification-needed verification-needed-impish
Revision history for this message
Ivan Kapelyukhin (ikapelyukhin) wrote :

TEST CASE:
1. modified an image's series file to use disk-image-uefi instead of disk-image
2. built an image

VERIFICATION DONE
Image is built successfully, BIOS disk image isn't built.

tags: added: verification-done verification-done-impish
removed: verification-needed verification-needed-impish
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.742.5

---------------
livecd-rootfs (2.742.5) impish; urgency=medium

  * Split UEFI image out of `disk-image` series file into
    `disk-image-uefi`. (LP: #1961760)

 -- Ivan Kapelyukhin <email address hidden> Thu, 03 Mar 2022 15:53:10 +0100

Changed in livecd-rootfs (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Ivan, or anyone else affected,

Accepted livecd-rootfs into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.664.41 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
removed: verification-done
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Ivan, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.58 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in livecd-rootfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Ivan Kapelyukhin (ikapelyukhin) wrote :

TEST CASE:
1. modified focal and bionic image's series file to use disk-image-uefi instead of disk-image
2. built the images

VERIFICATION DONE
Images are built successfully, BIOS disk images aren't built.

tags: added: verification-done verification-done-bionic verification-done-focal
removed: verification-needed verification-needed-bionic verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.664.41

---------------
livecd-rootfs (2.664.41) focal; urgency=medium

  [ Ivan Kapelyukhin ]
  * Split UEFI image out of `disk-image` series file into
    `disk-image-uefi`. (LP: #1961760)

  [ Thomas Bechtold ]
  * Optionally (when ALLOW_CORE_SNAP env var is set) allow to install
    core snap. Still needed by some CPC projects. (LP: #1964303)

 -- Thomas Bechtold <email address hidden> Fri, 04 Mar 2022 14:00:16 +0100

Changed in livecd-rootfs (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.525.58

---------------
livecd-rootfs (2.525.58) bionic; urgency=medium

  * Split UEFI image out of `disk-image` series file into
    `disk-image-uefi`. (LP: #1961760)

 -- Ivan Kapelyukhin <email address hidden> Thu, 03 Mar 2022 15:59:26 +0100

Changed in livecd-rootfs (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.