scilab 6.1.1+dfsg2-3 fail to build

Bug #1969227 reported by Matthieu Clemenceau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
scilab (Ubuntu)
Fix Released
Undecided
Graham Inggs

Bug Description

scilab 6.1.1+dfsg2-3 was uploaded on Nov 11 2021 and has failed to build ever since

https://launchpad.net/ubuntu/+source/scilab/6.1.1+dfsg2-3/+build/22400494

https://launchpadlibrarian.net/596601979/buildlog_ubuntu-jammy-amd64.scilab_6.1.1+dfsg2-3_BUILDING.txt.gz

Here is the build error
../../modules/core/includes/pause.h:18:18: error: conflicting declaration of C function ‘void pause()’
   18 | CORE_IMPEXP void pause(void);
      | ^~~~~
In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                 from /usr/include/signal.h:328,
                 from ../../modules/threads/includes/Thread_Wrapper.h:53,
                 from ../../modules/ast/includes/system_env/threadmanagement.hxx:21,
                 from src/cpp/pause.cpp:15:
/usr/include/unistd.h:489:12: note: previous declaration ‘int pause()’
  489 | extern int pause (void);
      | ^~~~~
src/cpp/pause.cpp:22:6: error: ambiguating new declaration of ‘void pause()’
   22 | void pause(void)
      | ^~~~~
In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                 from /usr/include/signal.h:328,
                 from ../../modules/threads/includes/Thread_Wrapper.h:53,
                 from ../../modules/ast/includes/system_env/threadmanagement.hxx:21,
                 from src/cpp/pause.cpp:15:
/usr/include/unistd.h:489:12: note: old declaration ‘int pause()’
  489 | extern int pause (void);
      | ^~~~~

It appears scilab core module has a function called pause that conflicts with the standard unistd pause function.

I made a patch that allow scilab to build and I tested from my ppa.
This patch simply rename the function to scipause. This doesn't feel very elegant and there might be a better solution. I'll leave it up to more experience folks to decide if this needs rework :)

Revision history for this message
Matthieu Clemenceau (mclemenceau) wrote :
Revision history for this message
Matthieu Clemenceau (mclemenceau) wrote :
Graham Inggs (ginggs)
Changed in scilab (Ubuntu):
assignee: nobody → Graham Inggs (ginggs)
status: New → In Progress
Graham Inggs (ginggs)
Changed in scilab (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Sylvestre Ledru (sylvestre) wrote :

Yeah, this is good enough!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package scilab - 6.1.1+dfsg2-3ubuntu1

---------------
scilab (6.1.1+dfsg2-3ubuntu1) jammy; urgency=medium

  * Fixed FTBFS due to conflict between signal.h pause function and scilab
    pause() function. renamed it to scipause (LP: #1969227)

 -- Matthieu Clemenceau <email address hidden> Thu, 14 Apr 2022 17:30:04 -0500

Changed in scilab (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.