[SRU] Fix None comparison when sorting by `updated_at`

really sorry... this belongs into python-heat, not puppet-heat

New OpenStack releases have the fix already in the following package versions:

Wallaby - heat_16.1.0-0ubuntu1~cloud0
Yoga - heat_18.0.0-0ubuntu1.2~cloud0
Zed - heat_19.0.0-0ubuntu1.2~cloud0

A new Xena release containing this fix is currently in -proposed.

https://bugs.launchpad.net/cloud-archive/+bug/2019763

That'll certainly supersede this one, so I'll wait on its release and do SRU for Ussuri & Victoria only.

Thanks Pon. Merged and uploaded to victoria-staging and the focal unapproved queue [1].

[1] https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=heat

Hello Andreas, or anyone else affected,

Accepted heat into victoria-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:victoria-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-victoria-needed to verification-victoria-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-victoria-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Xena has fix in 1:17.0.2-0ubuntu1~cloud0 (released via https://bugs.launchpad.net/cloud-archive/+bug/2019763).

Hello Andreas, or anyone else affected,

Accepted heat into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/heat/1:14.2.0-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Can you please clarify the error in the [test plan]? I suppose at some point you will get something like
"'<' not supported between instances of 'datetime.datetime' and 'NoneType'"? Just so that someone following the test plan knows what to expect.

Hello Andreas, or anyone else affected,

Accepted heat into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Following the reproducer steps:
 - create a project and nova instances using > 1 vcpus in that project
 - create a stack with a OS::Nova::Quota resource managing the project's quotas
 - change the vcpu quota to an invalid value (i.e. 0) and update the stack three times
 - set a valid quota and update the stack again

was able to reproduce the issue with heat 1:14.2.0-0ubuntu1.1 and verified that the heat 1:15.1.0-0ubuntu1~cloud1 fixes it.

Attached the logs and test deplyoyment for Victoria.

Similarly completed testing for Ussuri too.

Commands, stack template, etc can be seen in the attached log.

The verification of the Stable Release Update for heat has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package heat - 1:15.1.0-0ubuntu1~cloud1
---------------

 heat (1:15.1.0-0ubuntu1~cloud1) focal-victoria; urgency=medium
 .
   [ Ponnuvel Palaniyappan ]
   * d/p/lp2019175.patch: Fix None comparision when sorting
     by `updated_at` (LP: #2019175)
 .
   [ Corey Bryant ]
   * d/p/lp2019175.patch: Updated patch from upstream stable/victoria branch.

Has this actually been verified for focal? The comment only claims to be testing for ussuri, and doesn't include any version numbering we could use to verify what packages were actually tested.

@raof, The victoria verification was done on Focal. As there's only two new packages were created (ussuri & victoria UCA packages), I assumed there's no separate focal release and marked it complete based on focal-victoria verification. Corey can confirm whether a separate Ubuntu package for Focal will be created & released.

Hi Pon, The package that Andreas accepted into focal-proposed is the one to test for focal (https://launchpad.net/ubuntu/+source/heat/1:14.2.0-0ubuntu2). That was also backported to ussuri-proposed (on bionic) for testing.

@pponnuvel the package in focal-proposed needs to be verified and the package in bionic-ussuri/proposed also needs to be verified. Once both are verified you can set verification-done-focal verification-ussuri-done respectively. It seems that you have verified bionic-ussuri/proposed so i will leave that tag as-is but not focal-proposed so I will set that tag back to verification-needed-focal.

Just to clarify, the previous two verification I did were using:

1:14.2.0-0ubuntu2~cloud0 (on Bionic, ussuri-proposed)
1:15.1.0-0ubuntu1~cloud1 (on Focal, victoria-proposed)

Corey confirmed (also clarified by Ed) a separate SRU verification for Focal will be needed.
So I'll do another verification using 1:14.2.0-0ubuntu2 on Focal. Thanks all for clearing it up!

Attached SRU logs using 1:14.2.0-0ubuntu2

Marked all verifications as complete.

Done 3 for:

1:14.2.0-0ubuntu2~cloud0 (on Bionic, ussuri-proposed)
1:15.1.0-0ubuntu1~cloud1 (on Focal, victoria-proposed)
1:14.2.0-0ubuntu2 (on Focal, focal-proposed)

Looks like I forgot to attach the Focal verification log. Attaching here.

This bug was fixed in the package heat - 1:14.2.0-0ubuntu2

---------------
heat (1:14.2.0-0ubuntu2) focal; urgency=medium

  * d/p/lp2019175.patch: Fix None comparision when sorting
    by `updated_at` (LP: #2019175)

 -- Ponnuvel Palaniyappan <email address hidden> Mon, 15 May 2023 17:37:30 +0100

The verification of the Stable Release Update for heat has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package heat - 1:14.2.0-0ubuntu2~cloud0
---------------

 heat (1:14.2.0-0ubuntu2~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 heat (1:14.2.0-0ubuntu2) focal; urgency=medium
 .
   * d/p/lp2019175.patch: Fix None comparision when sorting
     by `updated_at` (LP: #2019175)