Ubuntu
r8125 package

r8125-dkms FTBS with linux 6.2 on jammy

Bug #2023620 reported by Andrea Righi
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
r8125 (Ubuntu)
Fix Released
Medium
Unassigned
Jammy
Fix Released
Medium
Andrea Righi

Bug Description

[Impact]

The rtl 8125 driver fails to build with linux 6.2 on jammy:

/var/lib/dkms/r8125/9.007.01/build/r8125.h:619:57: error: too many arguments to function ‘netif_napi_add’
  619 | #define RTL_NAPI_CONFIG(ndev, priv, function, weight) netif_napi_add(ndev, &priv->napi, function, weight)
      | ^~~~~~~~~~~~~~

[Test case]

 $ sudo apt install r8125-dkms

Results with the fix applied:

 - hwe kernel 6.2:

...
Get:1 http://archive.ubuntu.com/ubuntu jammy-proposed/multiverse amd64 r8125-dkms all 9.007.01-3ubuntu0.2 [93.0 kB]
...
Building for 6.2.0-26-generic
Building initial module for 6.2.0-26-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

r8125.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.2.0-26-generic/updates/dkms/

 - release kernel 5.15:

...
Get:1 http://archive.ubuntu.com/ubuntu jammy-proposed/multiverse amd64 r8125-dkms all 9.007.01-3ubuntu0.2 [93.0 kB]
...
Building for 5.15.0-79-generic
Building initial module for 5.15.0-79-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

r8125.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-79-generic/updates/dkms/

[Fix]

Backport the patch(es) from lunar to properly support the new linux 6.2 kernel ABI.

[Regression potential]

We may experience networking regressions in those systems that are using the r8125 network driver.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: r8125-dkms 9.007.01-3ubuntu0.1
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Tue Jun 13 05:32:44 2023
PackageArchitecture: all
SourcePackage: r8125
UpgradeStatus: No upgrade log present (probably fresh install)

See original description
Revision history for this message
Andrea Righi (arighi) wrote :
Revision history for this message
Andrea Righi (arighi) wrote :

debdiff to support linux-6.2 in jammy.

Ubuntu Foundations Team Bug Bot (crichton)
tags: added: patch
Alberto Milone (albertomilone)
Changed in r8125 (Ubuntu Jammy):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Andrea Righi (arighi)
Revision history for this message
Robie Basak (racb) wrote :

Please fix the Test Plan to include testing for both the release kernel and the HWE kernel.

Changed in r8125 (Ubuntu Jammy):
status: In Progress → Incomplete
Revision history for this message
Andrea Righi (arighi) wrote :

Test plan updated with the test results both for the release kernel and HWE kernel.

description: updated
Changed in r8125 (Ubuntu Jammy):
status: Incomplete → In Progress
Andrea Righi (arighi)
Changed in r8125 (Ubuntu):
assignee: nobody → Robie Basak (racb)
importance: Undecided → Medium
Revision history for this message
Robie Basak (racb) wrote :

Please do not assign me to bugs for SRU review.

Changed in r8125 (Ubuntu):
assignee: Robie Basak (racb) → nobody
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted r8125 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/r8125/9.007.01-3ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in r8125 (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Andrea Righi (arighi)
tags: added: verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Robie Basak (racb) wrote :

Swapping the tags back as this is still awaiting documented verification. Please see the instructions in comment 6.

tags: added: verification-needed-jammy
removed: verification-done-jammy
Timo Aaltonen (tjaalton)
Changed in r8125 (Ubuntu):
status: New → Fix Released
Revision history for this message
Andrea Righi (arighi) wrote :

We do not have the hardware to verify if the new driver is working correctly, so the best we can do is to test-build the module.

Test plan (in the bug description at the top) has been updated reporting the exact version of the package that has been tested with the positive test results (both with the latest release kernel and the latest new HWE 6.2 kernel).

description: updated
tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Chris Halse Rogers (raof) wrote :

Please report verification results in a *comment* on the bug instead of editing the bug description to include the verification.

It makes it difficult to follow when the bug description also includes a demonstration that the bug does not exist! :)

Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for r8125 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package r8125 - 9.007.01-3ubuntu0.2

---------------
r8125 (9.007.01-3ubuntu0.2) jammy; urgency=medium

  * Support Linux 6.2 (LP: #2023620):
    - debian/patches/linux6.1.patch

 -- Andrea Righi <email address hidden> Tue, 13 Jun 2023 07:11:09 +0000

Changed in r8125 (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.