Merge rsyslog 8.2306.0-2

Bug #2028935 reported by Heinrich Schuchardt
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rsyslog (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Debian has upgraded rsyslog to 8.2306.0-2.

Related branches

Changed in rsyslog (Ubuntu):
assignee: nobody → Heinrich Schuchardt (xypron)
Revision history for this message
Heinrich Schuchardt (xypron) wrote :
Changed in rsyslog (Ubuntu):
assignee: Heinrich Schuchardt (xypron) → nobody
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

A build of rsyslog - 8.2306.0-2ubuntu1 is available in ppa:xypron/merge-from-debian.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I reviewed the PR, and there are fixes needed for the DEP8 test that debian introduced in 8.2306.0-2.

Changed in rsyslog (Ubuntu):
assignee: nobody → Heinrich Schuchardt (xypron)
status: New → In Progress
Lukas Märdian (slyon)
Changed in rsyslog (Ubuntu):
status: In Progress → Incomplete
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

I updated the merge request to fix the autopkgtest failure (https://code.launchpad.net/~xypron/ubuntu/+source/rsyslog/+git/rsyslog/+merge/447986).

Changed in rsyslog (Ubuntu):
status: Incomplete → Confirmed
assignee: Heinrich Schuchardt (xypron) → nobody
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

I suppose the new merge is https://code.launchpad.net/~xypron/ubuntu/+source/rsyslog/+git/rsyslog/+merge/449720, is this right?

I linked it to this bug.

Revision history for this message
Heinrich Schuchardt (xypron) wrote :

As Debian has a new version I need to respin again.

Changed in rsyslog (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Julian Andres Klode (juliank) wrote :

Heinrich please note that the previous Debian version is a bug fix upload that is adequate to go in now (that we might want for the `Update logcheck rules for latest debian defaults.
` bug fix), whereas the new Debian version is a new upstream release that has to wait for next cycle most likely.

Changed in rsyslog (Ubuntu):
assignee: nobody → Julian Andres Klode (juliank)
status: Incomplete → Triaged
status: Triaged → In Progress
Changed in rsyslog (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

Autopkgtest on armhf shows these unmatched lines in the logcheck test. They do not appear on other architectures.

291s =-=-=-=-=-=-=
291s 2023-08-31T21:15:17.643352+00:00 autopkgtest-lxd-xjetox rsyslogd[1792]: rsyslogd: imklog: cannot open kernel log (/proc/kmsg): Permission denied.
291s 2023-08-31T21:15:17.643426+00:00 autopkgtest-lxd-xjetox rsyslogd[1792]: rsyslogd: activation of module imklog failed [v8.2306.0 try https://www.rsyslog.com/e/2145 ]
291s 2023-08-31T21:15:17.644738+00:00 autopkgtest-lxd-xjetox rsyslogd: imklog: cannot open kernel log (/proc/kmsg): Permission denied.
291s 2023-08-31T21:15:17.644899+00:00 autopkgtest-lxd-xjetox rsyslogd: activation of module imklog failed [v8.2306.0 try https://www.rsyslog.com/e/2145 ]
291s Aug 31 21:15:17 autopkgtest-lxd-xjetox rsyslogd[1792]: rsyslogd: imklog: cannot open kernel log (/proc/kmsg): Permission denied.
291s Aug 31 21:15:17 autopkgtest-lxd-xjetox rsyslogd[1792]: rsyslogd: activation of module imklog failed [v8.2306.0 try https://www.rsyslog.com/e/2145 ]
291s Aug 31 21:15:17 autopkgtest-lxd-xjetox rsyslogd[1792]: imklog: cannot open kernel log (/proc/kmsg): Permission denied.
291s Aug 31 21:15:17 autopkgtest-lxd-xjetox rsyslogd[1792]: activation of module imklog failed [v8.2306.0 try https://www.rsyslog.com/e/2145 ]

The permissions are specific to the setup of the test container. We should add the messages to the list of expected messages (debian/rsyslog.logcheck.ignore.server).

Changed in rsyslog (Ubuntu):
assignee: Julian Andres Klode (juliank) → Heinrich Schuchardt (xypron)
status: Fix Committed → In Progress
Revision history for this message
Heinrich Schuchardt (xypron) wrote :
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

rsyslog - 8.2306.0-2ubuntu2 is available in ppa:xypron/rsyslog

Revision history for this message
Heinrich Schuchardt (xypron) wrote :

The last update was needed because on armhf additional messages related to authorization in our autopkgtest build container appear.

Changed in rsyslog (Ubuntu):
assignee: Heinrich Schuchardt (xypron) → nobody
Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Thank you, your latest debdiff LGTM!

Remember, we're currently in feature freeze, so every upload/change should reference a corresponding bug report on Launchpad. I'll reference this LP bug for you in the debian/changelog file.

Also, I'll split up your debdiff into logical commits, to do a clean git-ubuntu upload.

I searched for (and found) evidence that the autopkgtest failure is actually fixed with those changes (please remember to mention your autopkgtest results besides your PPA test build in the future):
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-xypron-rsyslog/mantic/armhf/r/rsyslog/20230904_113354_6b2f1@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-xypron-rsyslog/mantic/amd64/r/rsyslog/20230904_112824_862bb@/log.gz
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-xypron-rsyslog/mantic/arm64/r/rsyslog/20230904_114245_bbef8@/log.gz

Edit: https://launchpad.net/ubuntu/+source/rsyslog/8.2306.0-2ubuntu2

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.8 KiB)

This bug was fixed in the package rsyslog - 8.2306.0-2ubuntu2

---------------
rsyslog (8.2306.0-2ubuntu2) mantic; urgency=medium

  * Amend list of expected messages d/rsyslog.logcheck.ignore.server
    to fix armhf autopkgtest (LP: #2028935)

rsyslog (8.2306.0-2ubuntu1) mantic; urgency=medium

  * Merge with Debian unstable (LP: #2028935)
  * New change:
    - d/test/logcheck: fix failures caused by apparmor and timing
  * Remaining changes:
    - d/00rsyslog.conf, d/rsyslog.postinst, d/rsyslog.install: Install
      tmpfiles.d snippet to ensure that the syslog group can write into
      /var/log/.
    - debian/50-default.conf: set of default rules for syslog
      + debian/50-default.conf: separated default rules
      + d/rsyslog.install: install default rules
      + d/rsyslog.postrm: clear default rules on purge
      + d/rsyslog.postrm: remove conf file in postrm on purge. manage with ucf
      + d/rsyslog.postinst: Adapt script to use ucf for Ubuntu's config files
      + debian/control: Add Depends for ucf
    - debian/rsyslog.conf:
      + enable $RepeatedMsgReduction to avoid bloating the syslog file.
      + enable $KLogPermitNonKernelFacility for non-kernel klog messages
      + Run as syslog:syslog, set $FileOwner to syslog
      + Remove rules moved to 50-default.conf
    - Add AppArmor profile, enabled by default, with support for
      AppArmor configuration snippets:
      + d/rsyslog.install: install apparmor rule
      + d/rsyslog.postinst: remove disabling of apparmor on upgrades if
        we are upgrading from a version older than $now.
      + d/rules: use dh_apparmor to install profile before rsyslog is started
      + d/control: suggests apparmor (>= 2.3), Build-Depends on
        dh-apparmor
      + d/rsyslog.dirs: install /etc/apparmor.d/rsyslog.d
      + d/usr.sbin.rsyslogd apparmor profile for rsyslogd
      + d/{apparmor/rsyslog-mysql,rsyslog-mysql.install}: add apparmor
        profile for mysql plugin
      + d/{apparmor/rsyslog-pgsql,rsyslog-pgsql.install}: add apparmor
        profile for postgresql plugin
      + d/{apparmor/rsyslog-gnutls.apparmor,rsyslog-gnutls.install}: add
        apparmor profile for the gnutls plugin
      + d/{apparmor/rsyslog-openssl.apparmor,rsyslog-gnutls.install}: add
        apparmor profile for the openssl plugin
      + New script to reload apparmor profile:
        - d/rsyslog.service: reload apparmor profile in ExecStartPre and
          set StandardError to journal so we can see errors from the
          script
        - d/rsyslog.install: install reload-apparmor-profile
        - d/reload-apparmor-profile: script to reload the
          rsyslogd apparmor profile
      + d/NEWS: add info about apparmor changes in the Ubuntu packaging
      + d/rsyslog.docs, d/README.apparmor: explains how the dynamic
        component of the rsyslog apparmor profile is applied
      + d/README.apparmor.rsyslog.d, d/rsyslog.install: install a specific
        README file in the apparmor include directory for rsyslog
    - d/rules: Fix LDFLAGS to avoid segfault on receipt of first message
    - Drop [mm|pm]normalize modules, depending on liblognorm from universe.
      + d/rules: drop --enabl...

Read more...

Changed in rsyslog (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Heinrich Schuchardt (xypron) wrote :

I have added some waiting time in tests to hopefully overcome autopkgtest issues:
https://code.launchpad.net/~xypron/ubuntu/+source/rsyslog/+git/rsyslog/+merge/458517

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.