Ubuntu
wavemon package

encryption key display has a mistake

Bug #209727 reported by PinKing
6
Affects Status Importance Assigned to Milestone
wavemon (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: wavemon

Hello,

in some cases, the encryption key is not shown clearly in wavemon 0.4.0b-11.

Example: Your Key is

06060606060606060606060606

then wavemon displays this:

 6 6 6 6 6 6 6 6 6 6 6 6 6

It happens, if there is a hex-value smaller then 10 (16 dec), so the first zero will not be shown.

Here is the code in file info_scr.c function display_info()

   for (i = 0; i < info.keysize; i++) {
    sprintf(tmp, "%2X", info.key[i]); <- I think ,%02X", will solve the problem???
    waddstr_b(w_info, tmp);
   }

Hope you understand me. Excuse my bad english.

Yours sincerely, Pinking.

Tags: bitesize

Related branches

lp:ubuntu/karmic/wavemon
Daniel T Chen (crimsun)
Changed in wavemon:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Arnaud Soyez (weboide) wrote :
Revision history for this message
Arnaud Soyez (weboide) wrote :

I just noticed another "crucial" bug so here's the new debdiff that should be used to fix this bug and also fix: https://bugs.launchpad.net/ubuntu/+source/wavemon/+bug/209722

This is a debdiff against 0.4.0b-11.

Built and tested.

Steve Stalcup (vorian)
Changed in wavemon:
assignee: nobody → vorian
status: Confirmed → In Progress
Revision history for this message
Steve Stalcup (vorian) wrote :

Hi!

Thanks for your attention to this bug. Just two things:
1. can you please create diffs for the patch system (see debian/patches for series)
2. Please be a bit more verbose in your changelog. Explain what each patch is for, and close the named bugs with them.

As soon as you get these changes completed, the package will be ready for upload.

Thanks!
Steve

Changed in wavemon:
assignee: vorian → weboide
Revision history for this message
Arnaud Soyez (weboide) wrote :

Here's the new and fresh debdiff, done as requested! : )

Changed in wavemon:
assignee: weboide → nobody
status: In Progress → Confirmed
Revision history for this message
Steve Stalcup (vorian) wrote :

Excellent!

Thanks for your contribution to Ubuntu.

Changed in wavemon:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package wavemon - 0.4.0b-11ubuntu1

---------------
wavemon (0.4.0b-11ubuntu1) jaunty; urgency=low

  * Added 12_write_conf_read_only.diff: fixes segmentation fault when writing
    into a read-only conf file. (LP: #209722)
  * Added 13_enc_key_displayed_fix.diff: fixes encryption key display bug (" 6"
    into "06" for example). (LP: #209727)
  * Debian/control:
    - bumped standards version to 3.8.0
    - added homepage field
    - added ${misc:Depends}
    - updated maintainer to MOTU

 -- Arnaud Soyez <email address hidden> Sun, 28 Dec 2008 23:17:48 -0500

Changed in wavemon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.