Compiz Manager wrapper script modifies ENV environment variable

Bug #221661 reported by Richard Hansen
2
Affects Status Importance Assigned to Milestone
Compiz
Invalid
Undecided
compiz (Debian)
Fix Released
Unknown
compiz (Ubuntu)
Fix Released
Low
Michael Vogt

Bug Description

Binary package hint: compiz-core

In compiz-core for Hardy (1:0.7.4-0ubuntu6):

The Compiz Manager wrapper script (installed at /usr/bin/compiz) modifies the ENV environment variable, which interferes with interactive POSIX shells (/bin/sh but not /bin/bash). The variable should be called something else (perhaps 'COMPIZ_ENV'). The purpose served by the ENV variable in the wrapper script is not clear; a quick grep for 'ENV' in the compiz source did not reveal anything useful.

For more details on the standard meaning of the ENV environment variable, see the POSIX specifications at:
    http://www.opengroup.org/onlinepubs/000095399/basedefs/xbd_chap08.html
    http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_05_03
    http://www.opengroup.org/onlinepubs/009695399/utilities/sh.html#tag_04_128_08

Revision history for this message
Richard Hansen (rhansen) wrote :

I just noticed that the compiz-manager script does 'export $ENV' and not 'export ENV' (notice the missing dollar sign). Thus, ENV is not actually used by compiz outside of the compiz-manager script. This will be easy to fix -- I'll whip up a patch.

Changed in compiz:
assignee: nobody → a7x
status: New → In Progress
Revision history for this message
Richard Hansen (rhansen) wrote :

This patch should fix it

Changed in compiz:
assignee: a7x → nobody
status: In Progress → Confirmed
Changed in compiz:
status: Unknown → New
Revision history for this message
Travis Watkins (amaranth) wrote :

Why did you submit this bug to debian?

Revision history for this message
Richard Hansen (rhansen) wrote :

> Why did you submit this bug to debian?

Because it's also a bug in Debian, so I thought I would forward the bug upstream so that (a) Debian users can benefit from the fix, and (b) Ubuntu developers don't have to maintain yet another difference between the Ubuntu version and the Debian version.

Changed in compiz:
status: New → Fix Released
Changed in compiz:
status: Fix Released → New
Changed in compiz:
status: New → Confirmed
Changed in compiz:
status: Unknown → New
Changed in compiz:
status: Confirmed → Fix Released
Changed in compiz (Ubuntu):
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Richard Hansen (rhansen) wrote :

Debian fixed it, but a recent change reverted the fix.

Changed in compiz (Debian):
status: Fix Released → Unknown
Changed in compiz (Debian):
status: Unknown → New
Changed in compiz (Debian):
status: New → Confirmed
Michael Vogt (mvo)
Changed in compiz (Ubuntu):
assignee: nobody → Michael Vogt (mvo)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.8.2-0ubuntu12

---------------
compiz (1:0.8.2-0ubuntu12) karmic; urgency=low

  [ Stéphane Graber ]
  * debian/patches/034_compiz_manager_log:
   - Update compiz-manager to better guess the current log file.

  [ Michael Vogt ]
  * debian/patches/028_compiz_manager_blacklist:
    - remove GM965 from the blacklist again, the karmic intel
      driver should work fine with it
  * debian/patches/044_compiz-manager_do_not_modify_special_ENV_environment_variable.patch:
    - merged patch to not modify ENV (thanks to a7x), LP: #221661

 -- Michael Vogt <email address hidden> Wed, 03 Jun 2009 10:16:17 +0200

Changed in compiz (Ubuntu):
status: In Progress → Fix Released
Changed in compiz (Debian):
status: Confirmed → Fix Released
Revision history for this message
Stephen M. Webb (bregma) wrote :

Upstream bug tracker is no longer with us.

Changed in compiz:
importance: Unknown → Undecided
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.