Ubuntu
gtksourceview2 package

Highlighting for `popd` in sh.lang misspelled as `podp`

Bug #249582 reported by parren
6
Affects Status Importance Assigned to Milestone
GtkSourceView
Fix Released
Medium
gtksourceview2 (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

$ grep -C4 podp /usr/share/gtksourceview-2.0/language-specs/sh.lang
      <keyword>kill</keyword>
      <keyword>let</keyword>
      <keyword>local</keyword>
      <keyword>logout</keyword>
      <keyword>podp</keyword>
      <keyword>printf</keyword>
      <keyword>pushd</keyword>
      <keyword>pwd</keyword>
      <keyword>read</keyword>

Clearly, this should be `popd` not `podp`.

Tags: patch
Revision history for this message
Nathan Handler (nhandler) wrote :

I can confirm this in version 1.8.5-1. I will prepare a debdiff shortly.

Changed in gtksourceview:
assignee: nobody → nhandler
status: New → In Progress
Revision history for this message
Nathan Handler (nhandler) wrote :

Currently, gtksourceview FTBFS for me. I am currently not sure what is causing this. Here is the debdiff to fix this bug:

gtksourceview (1.8.5-1ubuntu1) intrepid; urgency=low

  * Add debian/patches/01-sh.lang-typo.patch (LP: #249582)
    - Replace 'podp' with 'popd' in gtksourceview/language-specs/sh.lang
  * Bump Standards-Version to 3.8.0
  * Move Homepage from Description to its own field

 -- Nathan Handler <email address hidden> Fri, 18 Jul 2008 14:56:48 -0500

I will gladly update it when someone prepares a debdiff to allow gtksourceview to be build from source again.

Changed in gtksourceview:
assignee: nhandler → nobody
status: In Progress → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your bug report, where did you notice the issue? gedit it hardy and intrepid uses gtksourceview2 and not gtksourceview, is this one still used? it would also makes sense to send the change to debian

Revision history for this message
parren (peter-arrenbrecht) wrote : Re: [Bug 249582] Re: Highlighting for `popd` in sh.lang misspelled as `podp`

In gedit. If you look at the original bug report, you will see I
grepped the lang spec for gtksourceview 2. Also, if I fix it in that
file, highlighting works ok in gedit.

> $ grep -C4 podp /usr/share/gtksourceview-2.0/language-specs/sh.lang

Revision history for this message
parren (peter-arrenbrecht) wrote :

Seems the fix Nathan posted is for gtksourceview 1, however. So it
seems to affect both versions.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The bug has been sent on http://bugzilla.gnome.org/show_bug.cgi?id=550687, since gtksourceview2 is used now could you attach a debdiff for this one?

Changed in gtksourceview:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: Confirmed → Triaged
Bug Watch Updater (bug-watch-updater)
Changed in gtksourceview:
status: Unknown → New
Nathan Handler (nhandler)
Changed in gtksourceview2:
assignee: desktop-bugs → nhandler
status: Triaged → In Progress
Revision history for this message
Nathan Handler (nhandler) wrote :

Here is a new debdiff for gtksourceview2. It also successfully builds in an Intrepid pbuilder. This patch only fixes a bug.

gtksourceview2 (2.3.2-0ubuntu2) intrepid; urgency=low

  * Add debian/patches/01-sh.lang-typo.patch (LP: #249582)
    - Replace 'podp' with 'popd' in gtksourceview/language-specs/sh.lang

 -- Nathan Handler <email address hidden> Wed, 03 Sep 2008 16:48:02 -0500

Changed in gtksourceview2:
assignee: nhandler → nobody
status: In Progress → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtksourceview2 - 2.3.2-0ubuntu2

---------------
gtksourceview2 (2.3.2-0ubuntu2) intrepid; urgency=low

  * Add debian/patches/01-sh.lang-typo.patch (LP: #249582)
    - Replace 'podp' with 'popd' in gtksourceview/language-specs/sh.lang

 -- Nathan Handler <email address hidden> Wed, 03 Sep 2008 16:48:02 -0500

Changed in gtksourceview2:
status: Confirmed → Fix Released
Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your work on the issue, upstream has fixed the bug to svn too now

Bug Watch Updater (bug-watch-updater)
Changed in gtksourceview:
status: New → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gtksourceview:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.