Ubuntu
grub-installer package

grub-installer not executing raid mbr code path

Bug #270758 reported by Dustin Kirkland 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grub-installer (Ubuntu)
Fix Released
High
Dustin Kirkland 

Bug Description

Binary package hint: grub-installer

grub-installer is not executing raid mbr code path due to some faulty logic.

The code to blame looks like this:

    if type dmraid >/dev/null 2>&1; then
    ...
    elif type multipath >/dev/null 2>&1; then
    ...
    elif type mdadm >/dev/null 2>&1; then
    ...
    fi

If the "dmraid" utility is found, then the multipath and mdadm code blocks with simply not execute. This logic assumes that these utilities are mutually exclusive. This is faulty logic.

:-Dustin

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Debdiff patch attached. bzr branch coming...

:-Dustin

Changed in grub-installer:
assignee: nobody → kirkland
importance: Undecided → High
status: New → In Progress
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

TheMuso noted in IRC that this may be just surfacing now since he recently added dmraid to the default seeds. Previously, when dmraid wasn't present, the if/else would have fallen through to the mdadm. This became impossible with the default inclusion of dmraid.

:-Dustin

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Fixes pushed to:
 * lp:~kirkland/grub-installer/270758

:-Dustin

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grub-installer - 1.32ubuntu4

---------------
grub-installer (1.32ubuntu4) intrepid; urgency=low

  [ Dustin Kirkland ]
  * grub-installer: fix faulty logic (assumed mutual exclusion of dmraid,
    multipath, and md), (LP: #270758).

 -- Colin Watson <email address hidden> Tue, 16 Sep 2008 10:31:53 +0100

Changed in grub-installer:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.