System Cleaner Does Not Refresh Following Cleaning

Bug #274715 reported by nullack
6
Affects Status Importance Assigned to Milestone
system-cleaner (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: system-cleaner-gtk

Following cleanup, system cleaner still displays what it just cleaned. The workflow creates the potential for the user being confused about nothing actually being cleaned up. Once the user selects what they want to clean with the tick, and applies it, it would be more intuitive to have the old list refreshed to only show whatever was not cleaned up or nothing if all cruft was cleaned up.

Revision history for this message
Dean Loros (autocrosser) wrote :

Noted the same behavior--user is not sure that anything was "really" done.

Changed in system-cleaner:
status: New → Confirmed
Revision history for this message
Dean Loros (autocrosser) wrote :
Revision history for this message
to be removed (liw) wrote :

Found the reason for this: system-cleaner-gtk didn't refresh the apt.Cache() instance it has after it had removed packages. Therefore, when it refreshes the list of cruft after a cleanup, it finds the state of the system to be exactly as it was before the cleanup. Result: a confused system-cleaner-gtk, and a confused user.

I've fixed this in bzr.

Changed in system-cleaner:
status: Confirmed → Fix Committed
Revision history for this message
to be removed (liw) wrote :

Fixed packages are now in my PPA:

https://launchpad.net/~liw/+archive

Could you try that and tell me whether I'm actually correct in claiming that the bug is fixed?

Revision history for this message
Dean Loros (autocrosser) wrote :

I just reinstalled all my local apps--Lightscribe, RealPlayer & Nero. I asked System Cleaner to remove only Nero by unchecking all the other apps. Instead, it removed all the local items--the Lightscribe apps are installed in /opt as is RealPlayer--I would think that System Cleaner should ask before removing anything installed in /opt. I tried to install updated System Cleaner before this--there was no version change even after adding your PPA.

Revision history for this message
to be removed (liw) wrote :

If you didn't upgrade system-cleaner, then it's no wonder behavior did not change. The PPA contains version 1.9-0ubuntu1, could you make sure you get that installed and try again? If necessary by downloading the http://launchpadlibrarian.net/17985038/system-cleaner-gtk_1.9-0ubuntu1_all.deb file and installing that directly.

Revision history for this message
Dean Loros (autocrosser) wrote :

No--Lars, I said that even after I added your PPA to my sources list there was no update--Even now your PPA is showing version 1.8--you might check that the PPA has the correct version. Screenshot taken 1 min ago.

I downloaded your referenced file & will test/comment.

Revision history for this message
Dean Loros (autocrosser) wrote :

OK--I just tried 1.9--still same problem. I unchecked everything except one app--expected System Cleaner to remove only the checked app & instead it removed everything on the list--even items that were unchecked. All comments from my prior post still apply. I have three screenshots--list at startup of version 1.9--after clicking button/finish of job--shows that there was no change in state & then after restart of app showing that it removed everything on the list even though only one itemwas checked to be removed.

Revision history for this message
Dean Loros (autocrosser) wrote :

After cleanup--before restart of app.

Revision history for this message
Dean Loros (autocrosser) wrote :

After app restart.

Revision history for this message
to be removed (liw) wrote :

Dean, that looks like exactly the problems I have fixed in 1.9. What does running the following command on the command line give as the output?

dpkg --list system-cleaner system-cleaner-gtk

Revision history for this message
Dean Loros (autocrosser) wrote : Re: [Bug 274715] Re: System Cleaner Does Not Refresh Following Cleaning

Here is the output---

dean@linux:~/Desktop$ dpkg --list system-cleaner system-cleaner-gtk
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err:
uppercase=bad)
||/ Name Version Description
+++-==============-==============-============================================
ii system-cleaner 1.8-0ubuntu1 clean up a system so it's more like a
freshl
ii system-cleaner 1.9-0ubuntu1 clean up a system so it's more like a
freshl

Could it be using a preference config from 1.8? I just unstalled alhpa
6 last night--so I will retest to verify...

Cheers!!
Dean

Lars Wirzenius wrote:
> Dean, that looks like exactly the problems I have fixed in 1.9. What
> does running the following command on the command line give as the
> output?
>
> dpkg --list system-cleaner system-cleaner-gtk
>

Revision history for this message
Dean Loros (autocrosser) wrote :

OK--it still removed every local app I just installed--Lighscribe,
RealPlayer & Nero.....

Are there any logs I can get?

Cheers!!
Dean

Lars Wirzenius wrote:
> Dean, that looks like exactly the problems I have fixed in 1.9. What
> does running the following command on the command line give as the
> output?
>
> dpkg --list system-cleaner system-cleaner-gtk
>

Revision history for this message
to be removed (liw) wrote :

My error, that dpkg command needs a "|cat" added to the end so that dpkg doesn't cut off data because of terminal width. Please do the following:

dpkg --list system-cleaner system-cleaner-gtk | cat

and post the output. Then do this:

sudo dpkg --purge system-cleaner system-cleaner-gtk
sudo apt-get install system-cleaner-gtk
dpkg --list system-cleaner system-cleaner-gtk | cat

The last dpkg --list should report the same version number for both system-cleaner and system-cleaner-gtk: 1.9-0ubuntu1.

Thanks.

Revision history for this message
Dean Loros (autocrosser) wrote :
Download full text (4.3 KiB)

Lars--I have your PPA in my sources.list, but it looks like apt is
reporting 1.8 instead of 1.9. Not sure what is up....here is a snip from
my list---

Cheers!!
Dean

# PulseAudio Fixes & Adobe Flash - Preview Packages (psyke83)
deb http://ppa.launchpad.net/psyke83/ubuntu intrepid main
deb-src http://ppa.launchpad.net/psyke83/ubuntu intrepid main

#OpenOffice 3 beta
deb http://ppa.launchpad.net/openoffice-pkgs/ubuntu intrepid main
deb-src http://ppa.launchpad.net/openoffice-pkgs/ubuntu intrepid main

deb http://ppa.launchpad.net/liw/ubuntu intrepid main
deb-src http://ppa.launchpad.net/liw/ubuntu intrepid main
deb http://archive.ubuntu.com/ubuntu/ intrepid-proposed restricted main
multiverse universe
deb-src http://archive.ubuntu.com/ubuntu/ intrepid-proposed restricted
main multiverse universe

dean@linux:~/Desktop$ dpkg --list system-cleaner system-cleaner-gtk | cat
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err:
uppercase=bad)
||/ Name Version
            Description
+++-=========================================-=====================================-===========================================================
ii system-cleaner 1.8-0ubuntu1
            clean up a system so it's more like a freshly installed one
ii system-cleaner-gtk 1.9-0ubuntu1
            clean up a system so it's more like a freshly installed one
dean@linux:~/Desktop$ sudo dpkg --purge system-cleaner system-cleaner-gtk
[sudo] password for dean:
(Reading database ... 141684 files and directories currently installed.)
Removing system-cleaner-gtk ...
Removing system-cleaner ...
Purging configuration files for system-cleaner ...
Processing triggers for man-db ...
dean@linux:~/Desktop$ sudo apt-get install system-cleaner-gtk
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer
required:
  bsh-gcj bsh libxalan2-java imagemagick libxalan2-java-gcj
Use 'apt-get autoremove' to remove them.
The following extra packages will be installed:
  system-cleaner
The following NEW packages will be installed:
  system-cleaner system-cleaner-gtk
0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
Need to get 0B/26.0kB of archives.
After this operation, 299kB of additional disk space will be used.
Do you want to continue [Y/n]? y
Selecting previously deselected package system-cleaner.
(Reading database ... 141643 files and directories currently installed.)
Unpacking system-cleaner (from .../system-cleaner_1.8-0ubuntu1_all.deb) ...
Selecting previously deselected package system-cleaner-gtk.
Unpacking system-cleaner-gtk (from
.../system-cleaner-gtk_1.8-0ubuntu1_all.deb) ...
Processing triggers for man-db ...
Setting up system-cleaner (1.8-0ubuntu1) ...

Setting up system-cleaner-gtk (1.8-0ubuntu1) ...
dean@linux:~/Desktop$ dpkg --list system-cleaner system-cleaner-gtk | cat
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Cfg-files/Unpacked/Faile...

Read more...

Revision history for this message
to be removed (liw) wrote :

Dean, a-ha! I think there are two reasons why you're having trouble updating from the PPA:

1. Your sources.list says intrepid, not hardy.
2. I am an idiot and have uploaded to hardy in my PPA, instead of intrepid.

I've now uploaded version 1.10 to my PPA, for intrepid. I have also made sure system-cleaner-gtk depends on the same version of system-cleaner, so that there is no version skew. Also, system-cleaner-gtk now reports its version number when starting up.

Could you try again? I've made a number of other changes in 1.10 to make things work better.

Revision history for this message
Dean Loros (autocrosser) wrote :

The blinding white light at the end of the tunnel is the oncoming
freight train.....Do not feel like the only one---I too could have
caught this one & did not...

In any case, I will download & test this evening :)

Have a good evening & a great day tomorrow..

Cheers!!
Dean

Lars Wirzenius wrote:
> Dean, a-ha! I think there are two reasons why you're having trouble
> updating from the PPA:
>
> 1. Your sources.list says intrepid, not hardy.
> 2. I am an idiot and have uploaded to hardy in my PPA, instead of intrepid.
>
> I've now uploaded version 1.10 to my PPA, for intrepid. I have also made
> sure system-cleaner-gtk depends on the same version of system-cleaner,
> so that there is no version skew. Also, system-cleaner-gtk now reports
> its version number when starting up.
>
> Could you try again? I've made a number of other changes in 1.10 to make
> things work better.
>

Revision history for this message
Dean Loros (autocrosser) wrote :

Looks very good--glad to have the app working as it should....

Cheers!!!!
Dean

Revision history for this message
to be removed (liw) wrote :

Thank you for testing patiently, Dean.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package system-cleaner - 1.10.1-0ubuntu1

---------------
system-cleaner (1.10.1-0ubuntu1) intrepid; urgency=low

  * New uptream version. (LP: #279092)

system-cleaner (1.10-0ubuntu1) intrepid; urgency=low

  * New upstream version.
  * debian/control: Added versioned dependency from system-cleaner-gtk
    to system-cleaner, so that the packages don't get out of sync.
  * debian/control: Added build dependency on python-apt.

system-cleaner (1.9-0ubuntu1) hardy; urgency=low

  * New upstream version, fixes bugs:
    - "System Cleaner Does Not Refresh Following Cleaning" (LP: #274715)
    - "System Cleaner Cleanup Button Is Always Enabled" (LP: #274717)

 -- Lars Wirzenius <email address hidden> Mon, 06 Oct 2008 21:45:54 +0300

Changed in system-cleaner:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.