mythbuntu-lirc-generator fails silently if lircd.conf contains "raw_codes"

Bug #314760 reported by D C Ross
4
Affects Status Importance Assigned to Milestone
mythbuntu-lirc-generator (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: mythbuntu-lirc-generator

mythbuntu-lirc-generator will create empty .lircrc files if lircd.conf uses "raw_codes" instead of "codes". This occurs with version 0.20-0ubuntu1 of the package running under Ubuntu 8.10.

An example lircd.conf is at http://lirc.sourceforge.net/remotes/directv/RC32

The problem appears to be that parse_lircd in core.py only looks for "begin codes" and "end codes" lines. If these are not present then it fails to parse the remote and acts as though the lircd.conf was empty. Running with the -d debug flag only reveals that there was no remote parsed.

Ideally mythbuntu-lirc-generator should either parse the raw_codes section or provide the user with some feedback to explain what has happened.

Changed in mythbuntu-lirc-generator:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
muchtall (bugs-launchpad-john) wrote :

Created a patch that looks for "name" lines if raw_codes are used.

This is probably my first attempt at Python, as Perl is more my bag, but it WorksForMe(tm). Someone may want to take a quick look over it and make sure my code is clean/sane.

Revision history for this message
Mario Limonciello (superm1) wrote :

added to bzr #45

Changed in mythbuntu-lirc-generator (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mythbuntu-lirc-generator - 0.22-0ubuntu1

---------------
mythbuntu-lirc-generator (0.22-0ubuntu1) karmic; urgency=low

  [ Mario Limonciello ]
  * core:
    - Merge together remotes if two of the same named remotes are
      defined in the lircd.conf set. Unfortunately this has the side
      effect that if two buttons that perform the same action are
      defined with a different name, only the first gets selected.
    - Clean up muchtall's patch a little bit to simplify things.
    - Don't abort on OSErrors for not being able to make symlinks.
      Show a warning instead. (LP: #395346)
    - Add support for Freecom DVB-T "jump" button. (LP: #152539)
    - Add support for some missing keys on Medion X10 (LP: #194115)

  [ muchtall ]
  * core:
    - Support raw codes (LP: #314760)

 -- Mario Limonciello <email address hidden> Mon, 10 Aug 2009 03:20:19 -0500

Changed in mythbuntu-lirc-generator (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.