do-release-upgrade reboots computer if user enters something other than n when being prompted for reboot

Thanks for taking the time to report this bug and helping to make Ubuntu better. It would have been helpful to know which release of Ubuntu you were upgrading from and to but I was able to create this when upgrading from Intrepid to Jaunty and I'm working on a fix.

In DistUpgradeViewText.py:

_("Restart the system now [yN] "))

was being passed to askYesNoQuestion as a 3rd argument which became "default" and since default was not "No" it became "Yes". Personally, I think it'd be better if the logic were switched so:

if default == 'Yes':
  print _("Continue [Yn] "),
  ...
else:
  print _("Continue [yN] "),
  ....

but my branch will just fix the restart required bit.

This bug was fixed in the package update-manager - 1:0.99

---------------
update-manager (1:0.99) jaunty; urgency=low

  [ Michael Vogt ]
  * DistUpgrade/DistUpgradeController.py:
    - enable apport crash capturing during upgrades
  * DistUpgrade/DistUpgradeView.py:
    - create /var/lib/pycentral/pkgremove before the upgrade to
      help pycentral transition to the new python policy (thanks
      to doko)
  * ensure pidgin-libnotify is ugpraded (LP: #332328)
  * better wording for aborts (thanks to Gabor Kelemen and
    Jean-Baptiste Lallement), LP: #289303
  * wording fixes, thanks to Brian Murray and Gabor Kelemen
    LP: #269583
  * i18n fix, thanks to Gabor Kelemen, LP: #331821
  * support /etc/update-manager/release-upgrades.d/ directory
    for local overrides of the upgrade process. Useful to force
    certain site-specific options (like third party repository
    handling)
  * allow "[FreeSpace]\nSkipCheck=yes" override to skip free
    space checks (useful for testing)
  * support "[Sources"]\nAllowThirdParty=yes" override to skip
    commenting out of unknown repositories (LP: #147080)
  * debian/*.install:
    - updated for the new python layout (/u/l/p/dist-packages instead of
      /u/l/p/site-packages)
  * debian/rules:
    - use DH_PYCENTRAL=include-links instead of "nomove"
    - use "--install-layout=deb" in distutils
  * debian/control:
    - use "XS-Python-Version: all" instead of current
  * DistUpgrade/DistUpgradeCache.py:
    - fix modalias path in NvidiaDetector
  * data/glade/UpdateManager.glade:
    - add "settings" button
  * UpdateManager/UpdateManager.py:
    - open software-properties when settings button
      is clicked (LP: #334959)
    - keep track of launch times via gconf
      (/apps/update-manager/launch_time)
  * debian/control:
    - recommend software-properties-gtk

  [ Brian Murray ]
  * DistUpgrade/multiple files:
    - fixed typographical error
  * DistUpgrade/DistUpgradeViewText.py:
    - change "Restart required" default to N (LP: #328452)

 -- Michael Vogt <email address hidden> Tue, 03 Mar 2009 12:33:12 +0100