fix "deprecation warning printed on startup" and "incorrect selection length in statusbar"

Bug #329020 reported by Martin Olsson
2
Affects Status Importance Assigned to Milestone
ghex (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

will attach debdiff shortly that fixes the following two upstream bugs:

http://bugzilla.gnome.org/show_bug.cgi?id=564371
http://bugzilla.gnome.org/show_bug.cgi?id=564372

Related branches

Revision history for this message
Martin Olsson (mnemo) wrote :

I found during testing that cherry picking the two patches from above alone actually made another bug visible. Luckily that bug had also been fixed upstream already so anyway, therefore it's also necessary to pickup this bugfix from upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=526445

I've tested these three patches and they seem to work fine. I still see some regions not being invalidated when selecting and deselecting multiple rows at once but that issue is found both in the old ubuntu version of ghex and also in upstream. It's a separate bug.

Revision history for this message
Martin Olsson (mnemo) wrote :

Requesting sponsorship for upload in universe. My first debdiff! Whee!! :-)

Revision history for this message
Iain Lane (laney) wrote :

Uploaded, thanks for your contribution. I made two very minor changes:
 * You don't need to repeat the same bug number more than once in the changelog
 * You need to update the maintainer in debian/control (run update-maintainer) to show that the package has been modified by Ubuntu.

Please also forward these patches to Debian (try the submittodebian tool in the ubuntu-dev-tools package)

Thanks!

Changed in ghex:
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ghex - 2.22.0-1ubuntu2

---------------
ghex (2.22.0-1ubuntu2) jaunty; urgency=low

  * debian/patches/10_fix_keyboard_selection_always_start_at_offset_zero.patch:
    when cursor is at file offset other than zero and user presses SHIFT-DOWN
    ghex used to incorrectly select all bytes from offset zero. The patch comes
    from upstream SVN revision r1206. (LP: #329020)

  * debian/patches/20_fix_deprecation_warning_printed_to_terminal_on_startup.patch:
    prevent ghex from calling a deprecated API on startup causing a warning to be
    printed to the terminal. Patch from upstream SVN revision r1222.

  * debian/patches/30_fix_status_bar_showing_incorrect_selection_length.patch:
    make sure the correct number of "selected bytes" is printed in the statusbar.
    Patch from upstream SVN revision r1226.

 -- Martin Olsson <email address hidden> Fri, 13 Feb 2009 15:47:15 +0100

Changed in ghex:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.