Panel should add the messaging indicator for users upgrading

Bug #340777 reported by Ted Gould
4
Affects Status Importance Assigned to Milestone
gnome-panel (Ubuntu)
Fix Released
High
Michael Vogt
Jaunty
Fix Released
High
Michael Vogt

Bug Description

Binary package hint: gnome-panel

On upgrade the Indicator applet should be added to the panel so that users can respond to messages that they see in their notifications. It should be inserted at the end of the applet stack as much as possible and aligned right. So, it should appear slightly to the left of the notification area. This isn't the default placement with a clean install, but it should make the insertion MUCH easier and has been deemed good for putting it on the panel.

I don't think that we need to worry too much about panels that have been radically configured, there will be some misplacement, but considering it's only an insertion we can let the panels dynamic reallocation take care of making it reasonable.

For the individal applet settings (locking,etc.) please copy them out of the GNOME Panel defaults.

Thank you.

Related branches

Changed in gnome-panel:
assignee: nobody → seb128
importance: Undecided → High
milestone: none → ubuntu-9.04-beta
status: New → Confirmed
Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Ken VanDine (ken-vandine) wrote :

I have tested this script a number of times, including in a pristine VM which was installed from an iso from before notify-osd was included. I did a dist-upgrade then ran the script. The applet was added just to the left of the notification area.

I also tested the scenario without a notification area, and got the desired error message.

Looks good!

Revision history for this message
Ken VanDine (ken-vandine) wrote :

I have had a couple random placements of the applet when running this script. Here is a gconf dump from when it was added to the left of the menu.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Screenshot as well

Revision history for this message
Michael Vogt (mvo) wrote :

I modified the script a bit more to not allow position = 0 and seb told me about conditional autostart based on gconf values. I think this is what we are going to do

Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :

I put a testversion into my ppa:
https://edge.launchpad.net/~mvo/+archive/ppa?field.name_filter=panel&field.status_filter=published&field.series_filter=any
please test and give me feedback. There maybe a race with the gconf calls and the gconf that the panel is doing during statup. I tried a time.sleep(60) to avoid that in the migrate script but that caused it to not run at all. I have not investigated further yet.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

It isn't running for me, I am seeing the gconf key is getting set to false but the applet never gets added

Revision history for this message
Michael Vogt (mvo) wrote :

I pushed a new version into my PPA - it has some improvements and is also much more verbose. So if it fails, .xsession-errors should tell us why.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Still not running.

I tested this again, in a VM installed from a early feb jaunty iso and updated to current.

ii gnome-panel 1:2.25.92-0ubuntu2.1 launcher and docking facility for GNOME
ii gnome-panel-data 1:2.25.92-0ubuntu2.1 common files for the GNOME Panel
ii libpanel-applet2-0 1:2.25.92-0ubuntu2.1 library for GNOME Panel applets

Attached is the .xsession-errors log

Revision history for this message
Ken VanDine (ken-vandine) wrote :

gconf dump of /apps/panel

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Latest .xsession-errors, after the applet was added

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Here is a patch to the script, it was just a typo

Revision history for this message
Michael Vogt (mvo) wrote :

typo fix uploaded in my ppa

Michael Vogt (mvo)
Changed in gnome-panel (Ubuntu Jaunty):
assignee: seb128 → mvo
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-panel - 1:2.26.0-0ubuntu2

---------------
gnome-panel (1:2.26.0-0ubuntu2) jaunty; urgency=low

  [ Michael Vogt ]
  * auto add indicator applet on upgrade (LP: #340777)
  * run the add-indicator-applet.py script after a shell
    sleep of 60s. using time.sleep(60) inside the python
    code does not work as expected makes it crash(!) deep inside
    liborbit2 on the first gconf.set_bool() call

  [ Ted Gould ]
  * debian/patches/25_dynamic_fusa_detection.patch: Adjusting to
    make it also change the tooltip saying whether there is logout
    available on the system menu based on whether there is.
    (LP: #335242)

 -- Michael Vogt <email address hidden> Wed, 18 Mar 2009 21:06:46 +0100

Changed in gnome-panel:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.