Ubuntu
gajim package

config rewrites not posix safe

Bug #349661 reported by Jamin W. Collins on 2009-03-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gajim (Ubuntu)	Fix Released	Medium	Nafallo Bjälevik
	Jaunty	Fix Released	Medium	Nafallo Bjälevik

Bug Description

Binary package hint: gajim

gajim does not flush or sync configuration file rewrites, which it does frequently (separate report). This can lead to data loss with ext4 and potentially other filesystems.

I believe the attached patch should correct this. I'm currently using it without issue here.

ProblemType: Bug
Architecture: amd64
DistroRelease: Ubuntu 9.04
NonfreeKernelModules: nvidia ath_hal
Package: gajim 0.12.1-0ubuntu2 [modified: usr/share/gajim/src/common/optparser.py]
ProcEnviron:
PATH=(custom, user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: gajim
Uname: Linux 2.6.28-11-generic x86_64

Tags:

Related branches

lp:ubuntu/karmic/gajim

Revision history for this message

Jamin W. Collins (jcollins) wrote on 2009-03-27:

Dependencies.txt Edit (6.1 KiB, text/plain; charset="utf-8")

Revision history for this message

Jamin W. Collins (jcollins) wrote on 2009-03-27:

gajim-config-write-sync.patch Edit (628 bytes, text/x-diff)

Updated version of the patch, makes the explicit file removal only happen on windows. It is unnecessary on posix systems as the following rename is atomic.

Revision history for this message

Brian Murray (brian-murray) wrote on 2009-03-31:

Looking at the attachments in this bug report, I noticed that "gajim-config-write-sync.patch" was not flagged as a patch. A patch contains changes to an Ubuntu package that will resolve a bug and this attachment is one! Subsequently, I've checked the patch flag for it. In the future when submitting patches please use the patch checkbox as there are some Launchpad searches that use this feature. You can learn more about patch workflow at https://wiki.ubuntu.com/Bugs/Patches. Thanks for your contribution Jamin W. Collins!

Nafallo Bjälevik (nafallo) on 2009-04-02

Changed in gajim (Ubuntu Jaunty):
assignee:	nobody → nafallo
importance:	Undecided → Medium
status:	New → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-04-02:

This bug was fixed in the package gajim - 0.12.1-0ubuntu3

---------------
gajim (0.12.1-0ubuntu3) jaunty; urgency=low

  [ Ken VanDine ]
  * debian/patches/patches/add-indicator-support.patch:
    - Add support for the message indicator (LP: #340213)
  * debian/control:
    - Added a Recommends for indicate-python, to take advantage of
      the message indicator patch

  [ Nafallo Bjälevik ]
  * Convert all other patches to dpatches as well:
    - notify-osd.patch from James Westby
    - ubuntu-keyring.patch from Nafallo Bjälevik
  * debian/control:
    - Rework the package relations between Depends,
      Recommends and Suggestions a bit (LP: #348793)
  * debian/patches/config-write-sync.patch:
    - Make the explicit configuration file removal
      only happen on Windows. Thanks Jamin W. Collins.
      (LP: #349661)