Ubuntu
pybootchartgui package

[Improvement] Drawing of ticks and first chart

Bug #360943 reported by Hernando Torque
2
Affects Status Importance Assigned to Milestone
pybootchartgui (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: pybootchartgui

As we may see an updated version of pybootchartgui for Jaunty I've decided to fix three visual bugs:

* Cairo's standard line width is 2.0 so the first chart is stroked thicker than the rest.
* The first tick of a chart is painted at x-coordinate 0 (rel.) which overlaps the chart border.
* Cairo's standard line cap is BUTT, so the ticks will either overlap the chart's border or not join it.

Before/after of all three: http://img.xrmb2.net/images/101262.png

Patch attached (from rev. 120).

Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Hernando Torque (htorque) wrote :

Uhm, of course the added if-statement in 'draw_box_ticks' is not needed if starting 'range' at 'sec_w'.

Never post before the morning coffee. :P

Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)
Changed in pybootchartgui (Ubuntu):
importance: Undecided → Low
Brian Murray (brian-murray)
Changed in pybootchartgui (Ubuntu):
status: New → Triaged
Revision history for this message
Anders Norgaard (anders-norgaard) wrote :

Committed as r123.

http://code.google.com/p/pybootchartgui/source/detail?r=123

Thanks for the patch.

PS A bit related: I've also considered is shifting the graph 0.5 pixels to get sharp lines, http://cairographics.org/FAQ/#sharp_lines

Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)
Changed in pybootchartgui (Ubuntu):
status: Triaged → Fix Committed
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)
Changed in pybootchartgui (Ubuntu):
assignee: nobody → mrkanister
Revision history for this message
Hernando Torque (htorque) wrote :

> PS A bit related: I've also considered is shifting the graph 0.5 pixels to get sharp lines, http://cairographics.org/FAQ/#sharp_lines

I see (I only tested using SVGs so I didn't even notice that).

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pybootchartgui - 0+r124

---------------
pybootchartgui (0+r124) jaunty; urgency=low

  * New upstream revision:
    - Fix some drawing issues (lp: #342593)
    - Fix drawing bug (lp: #343215)
    - Empty bootcharts are now discovered (lp: #355952)
    - Fix incorrect seconds value for 60+ second boots (lp: #355954)
    - Fix parsing issue for process lines with spaces (lp: #356537)
    - Update slider position when zooming (lp: #358364)
    - Fix some drawing issue (lp: #360943, thanks to Hernando Torque)
  (thanks to biehl and Henning Niss for their active development)
  * debian/control:
    - Add depencies to 'python-gtk2' and 'python-cairo' (lp: #353699)

 -- Martin Mai <email address hidden> Sat, 18 Apr 2009 22:48:24 +0200

Changed in pybootchartgui (Ubuntu):
status: Fix Committed → Fix Released
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)
Changed in pybootchartgui (Ubuntu):
assignee: mrkanister → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.