Ubuntu
dwdiff package

Typo in package description

Bug #385276 reported by Reuben Thomas
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dwdiff (Debian)
Fix Released
Unknown
dwdiff (Ubuntu)
Fix Released
Low
Thierry Carrez

Bug Description

Binary package hint: dwdiff

"font-end fof the diff program that operates word by word" should be "front-end for the diff program that operates word by word"

ProblemType: Bug
Architecture: i386
Dependencies:

DistroRelease: Ubuntu 9.04
Package: dwdiff None [modified: /var/lib/dpkg/info/dwdiff.list]
ProcEnviron:
 PATH=(custom, user)
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: dwdiff
Uname: Linux 2.6.28-11-generic i686
UnreportableReason: This is not a genuine Ubuntu package

Related branches

lp:ubuntu/karmic/dwdiff
Bug Watch Updater (bug-watch-updater)
Changed in dwdiff (Debian):
status: Unknown → New
Revision history for this message
Charlie_Smotherman (cjsmo) wrote :

I have set up a bzr branch with this fix. https://code.edge.launchpad.net/~cjsmo/+junk/dwdiff

I am also attaching a diff of the changes.

Changed in dwdiff (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Charlie_Smotherman (cjsmo) wrote :

Found an additonal bug on the Debian BTS #504540. Attaching a new debdiff, these changes are also in the bzr branch.

Charlie_Smotherman (cjsmo)
Changed in dwdiff (Ubuntu):
status: Triaged → New
Revision history for this message
Thierry Carrez (ttx) wrote :

Could you explain why are you adding quilt to the Build-Depends ?
It's not used in the build...

Changed in dwdiff (Ubuntu):
importance: Wishlist → Low
status: New → Confirmed
Revision history for this message
Charlie_Smotherman (cjsmo) wrote :

The man page is provided by upstream and is included in the .orig.tar.gz. It is my understanding that any changes made outside of the debian directory should be done through some type of patch system. Is my understanding of this incorrect?

Revision history for this message
Thierry Carrez (ttx) wrote :

When modifying an existing package, the best practice is to keep whatever patchsystem the Debian packaging is already using. If the Debian package uses direct modification of files , then you should continue to do so.

In the dwdiff case, it doesn't use any patchsystem and you can see by looking at the current .diff.gz that it already modified files outside the debian/ directory. You should do the same.

Anyway, in your debdiff you patched man/dwdiff.1 directly so it's OK. It's just your addition of "quilt" build-dependency that is unnecessary, since you don't even call quilt from your debian/rules and you don't ship any patches in debian/.

Could you please provide a new debdiff without the build dep change (and the related changelog entry) ? Test that it builds and fixes both issues ?

Revision history for this message
Charlie_Smotherman (cjsmo) wrote :

New debdiff attached

Revision history for this message
Charlie_Smotherman (cjsmo) wrote :
Thierry Carrez (ttx)
Changed in dwdiff (Ubuntu):
assignee: nobody → Thierry Carrez (ttx)
status: Confirmed → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

Uploaded with minor changes:
- Version should be 1.4-1ubuntu1 and not 1.4-1ubuntu2 (previous was 1.4-1build1)
- Maintainer field did not follow new DebianMaintainerField rules

Thanks !

Changed in dwdiff (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dwdiff - 1.4-1ubuntu1

---------------
dwdiff (1.4-1ubuntu1) karmic; urgency=low

  * Fixed typo in debian/control (LP: #385276)
  * Fixed typo on man/dwdiff.1. This corrects debian bts bug #504540.

 -- Charlie Smotherman <email address hidden> Wed, 24 Jun 2009 04:49:47 +0500

Changed in dwdiff (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Andrea Veri (av) wrote :

removing u-u-s as sponsorship is not needed here.

Bug Watch Updater (bug-watch-updater)
Changed in dwdiff (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.