from poke_gnome_screensaver to turn_off_screensaver

Bug #40095 reported by Daniele Favara
8
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Medium
Colin Watson

Bug Description

i'm testing espresso on xubuntu, this is the first patch:

ubuntu uses gnome-screensaver, xubuntu xscreensaver, the idea is to check

- if os.path.isfile('/usr/bin/gnome-screensaver-command')
- elif os.path.isfile('/usr/bin/xscreensaver-command')

and to pass different args to the function that was

- poke_gnome_screensaver(self)

now called

- turn_off_screensaver(self,command,opt)

where:

 - gnome-screensaver-command --poke == xscreensaver-command --deactivate

i'll try to contact Kamion the maint, there are more patches needed for xubuntu that i'll send as soon as i get more familiar with the code

Revision history for this message
Daniele Favara (nomed) wrote : patch to add "xscreensaver-command --disable"

this patch is needed for espresso gtkui used in xubuntu livecd

Colin Watson (cjwatson)
Changed in espresso:
assignee: nobody → kamion
status: Unconfirmed → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

espresso (0.99.55) dapper; urgency=low

  * GTK frontend:
    - Add support for disabling xscreensaver as well as gnome-screensaver
      (thanks, Daniele Favara; closes: Malone #40095).
    - Set a window icon (closes: Malone #40052).
  * Update various translations from Rosetta.

 -- Colin Watson <email address hidden> Wed, 19 Apr 2006 10:59:20 +0100

Changed in espresso:
status: Fix Committed → Fix Released
Revision history for this message
Daniele Favara (nomed) wrote :

i' sorry if the patch title could be confising ... but within the patch the opt was correct (at least :) )

xscreensaver-command --disable

should be

xscreesaver-command --deactivate

Revision history for this message
Daniele Favara (nomed) wrote :

i re-open this bug as the it's still present ..

Changed in espresso:
status: Fix Released → Confirmed
Colin Watson (cjwatson)
Changed in espresso:
status: Confirmed → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

ubiquity (0.99.64) dapper; urgency=low

  * GTK frontend:
    - Use xscreensaver-command --deactivate, not --disable (closes: Malone
      #40095).
    - Hide "Set Time..." button if time-admin isn't present.
    - Recommend gnome-system-tools for time-admin.
  * KDE frontend:
    - Fix import of UbiquityUIBase (closes: Malone #40939).
  * Set the SIGPIPE handler back to the default before spawning
    debconffiltered subprocesses, so that they notice when the UI crashes
    rather than carrying merrily on and e.g. trashing the partition table
    (closes: Malone #40464). Whose bright idea was it to have Python install
    a SIGPIPE handler but then not bother to have the subprocess module
    remove it, eh?

 -- Colin Watson <email address hidden> Sun, 23 Apr 2006 19:07:52 +0100

Changed in ubiquity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.