Filezilla crashed on file resuming

StacktraceTop:CServer::operator< (this=0x882c178, op=@0x0) at server.cpp:335
CPathCache::Lookup (server=@0x0, source=@0xbfd185f0, subdir=
CFtpControlSocket::ChangeDir (this=0x8847990, path=DWARF-2 expression error: DW_OP_reg operations must be used either alone or in conjuction with DW_OP_piece.
CFtpControlSocket::FileTransfer (this=0x8847990, localFile=
CFileZillaEnginePrivate::FileTransfer (this=0x8778520,

This problem is caused by a race condition in the socket class of FileZilla.

Happens if CSocket::Disconnect() get called between the worker thread's call to getaddrinfo and re-obtaining the lock. In that case the worker thread continues to connect and ultimately sets the socket state to connected, despite the previous call to Disconnect.

The attached patch solves this problem.

Sorry for the duplicate, when I looked at this bug, it said it had been successfully patched. Alas, not in my case. Also, mine is when it fails to Upload, not download - but am guessing the flag (or whatever) is the same !!

This bug was fixed in the package filezilla - 3.3.1-1

---------------
filezilla (3.3.1-1) unstable; urgency=low

  * New upstream release (LP: #447224, #497836)
  * Added dpatch
  * Added 01_remove-xdg-check.dpatch: patch configure and configure.in so that
    it doesn't fail if xdg-open is not present at build time
  * Recommend xdg-utils
 -- Adrien Cunin <email address hidden> Mon, 15 Feb 2010 16:07:59 +0000

Well, it's back :-(

At first it would just quit, with no crash report, but this time it generated one. Same scenario .. a slowish link, not getting the connection in two attempts..

According to your original report, you're using karmic. The fix was uploaded to lucid. Please reopen this bug report if you still experience the problem in lucid. Thanks.

Sorry Phill, didn't realize you are not the reporter of this bug.
In any case, it turns out the fix is not included in 3.3.1, but only in more recent versions... I thought I checked this but obviously I failed somewhere, my mistake. I'm going to apply the patch to the package.

This bug was fixed in the package filezilla - 3.3.1-1ubuntu1

---------------
filezilla (3.3.1-1ubuntu1) lucid; urgency=low

  * Patches time: updated debian/patches/00list
  * Really fix the two bugs mentioned in the previous changelog entry; the
    patches for them were not actually in upstream 3.3.1:
     - 10_fix-socket-race-condition.dpatch (LP: #447224, upstream rev. 3601)
     - 11_fix-desktop-freeze.dpatch (LP: #497836, upstream rev. 3605)
     - 12_various-fixes.dpatch: 3 tiny patches recommended by and backported
       from upstream (rev. 3603, 3612, 3670)
  * 02_use-decimal-si-by-default.dpatch: by default, display file sizes using
    decimal base and SI units instead of just bytes; complies with Ubuntu
    UnitsPolicy
 -- Adrien Cunin <email address hidden> Wed, 10 Mar 2010 23:40:51 +0100