Warnings during build

Bug #452926 reported by Loïc Minier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
c3p0 (Ubuntu)
Fix Released
Low
James Page

Bug Description

Hi

There is a large number of warnings during the gcj-based build of c3p0 (NB: I'm quite surprized that it's not compatible with openjdk though as I used c3p0 with Sun's JDK in the past and would have thought it's easier to use openjdk than gcj here).

I think the very high number of warnings deserves some work, upstream and/or in the packaging (I think using the proper source compat level would help with a bunch).

  [javadoc] WARNING: Cannot locate class java.lang.Object referenced in class com.mchange.v2.c3p0.AbstractConnectionCustomizer
  [javadoc] WARNING: Error while loading class Connection
  [javadoc] WARNING: Error while loading class SQLException
  [javadoc] WARNING: Error while loading class Method
=> a bit worrying; looks like that part is not started properly, or build-deps are missing

    [javac] 1. WARNING in /build/buildd/c3p0-0.9.1.2/relproj/debuggen/src/classes/com/mchange/v1/util/IteratorUtils.java (at line 31)
    [javac] public final static Iterator EMPTY_ITERATOR = new Iterator()
    [javac] ^^^^^^^^
    [javac] Iterator is a raw type. References to generic type Iterator<E> should be parameterized
=> you might want to use an older source compat level or use a parametrized iterator

    [javac] 2. WARNING in /build/buildd/c3p0-0.9.1.2/src/classes/com/mchange/v2/c3p0/codegen/BeangenDataSourceGe
    [javac] nerator.java (at line 71)
    [javac] protected void generateExtraSerInitializers(ClassInfo info, Class superclassType, Property[] props, Class[] propTypes, IndentedWriter iw)
    [javac]
    [javac] ^^^^^^^^^^^^^^
    [javac] The type IndentedWriter is deprecated
=>self refs to depreacted types

    [javac] 119. WARNING in /build/buildd/c3p0-0.9.1.2/src/classes/com/mchange/v2/log/MLog.java
    [javac] (at line 222)
    [javac] { instance().getLogger().exiting( srcClass, srcMeth, result ); }
    [javac] ^^^^^^^^^^^^^^^^^^^^^^
    [javac] The static method getLogger() from the type MLog should be accessed in a static way
=> certainly typos

    [javac] 132. WARNING in /build/buildd/c3p0-0.9.1.2/src/classes/com/mchange/v2/beans/BeansUtils.java (at line 202)
    [javac] boolean rethrow = false;
    [javac] ^^^^^^^
    [javac] The local variable rethrow is never read
=> certainly a bug

Thanks,

Related branches

Mathias Gug (mathiaz)
Changed in c3p0 (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
James Page (james-page) wrote :

Updates based on some initial analysis of this package:

1) The version of c3p0 (which is the latest released version) is not compatible with Java 1.6 (which openjdk implements) hence it is compiled against gcj which implements Java 1.5.

2) gcj is by default alot more verbose with its warning messages than openjdk (which gives a general warning about deprecated API unless explicitly turned on).

3) The javadoc issues appear to be related to the use of gcj rather than openjdk (which gives a different set of errors).

I agree that it feels like this needs to be resolved by the upstream project; however the original c3p0 project appears to be relatively inactive so we may not get a fix.

Revision history for this message
James Page (james-page) wrote :

For information - limited use within Ubuntu but critical and in main.

James Page (james-page)
Changed in c3p0 (Ubuntu):
assignee: nobody → James Page (james-page)
status: Triaged → In Progress
James Page (james-page)
Changed in c3p0 (Ubuntu):
importance: Medium → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package c3p0 - 0.9.1.2-5ubuntu1

---------------
c3p0 (0.9.1.2-5ubuntu1) natty; urgency=low

  * Patched ant build files to make gcj behave more like openjdk (LP: #452926).
  * Enabled junit test suite for operation using gcj and hsqldb (LP: #452919).
  * Updated Standards-Version: 3.9.1, no changes.
 -- James Page <email address hidden> Fri, 25 Feb 2011 12:04:39 +0000

Changed in c3p0 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.