don't mess with the pc file

Bug #455614 reported by c7d2f5c8667d26fffd5e7772d632c76d
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Games
Fix Released
Medium
gnome-games (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

libsm-dev contains the sm.pc pkg-config file. This file has been changed from upstream's by moving the ice dependency from Requires to Requires.private. (The patch originated from debian.) This breaks building other packages that reasonably expect the pc file to be unmodified from upstream [e.g. https://bugzilla.gnome.org/show_bug.cgi?id=598837].

Please revert this change before karmic final!

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi chpe,

Please attach the output of `lspci -vvnn` and `dmesg`, and attach your /var/log/Xorg.0.log (and maybe Xorg.0.log.old) file from after reproducing this issue. If you're using a custom /etc/X11/xorg.conf please attach that as well.

[This is an automated message. Apologies if it has reached you inappropriately; please just reply to this message indicating so.]

tags: added: needs-xorglog
tags: added: needs-lspci-vvnn
Changed in libsm (Ubuntu):
status: New → Incomplete
Revision history for this message
c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

This is not an x server bug; therefore dmesg, lspci etc are irrelevant. The bug is in the -dev package's .pc file.

tags: removed: needs-lspci-vvnn needs-xorglog
Revision history for this message
Robert Ancell (robert-ancell) wrote :

The change in Ubuntu should be fixed because it is:
a) inconsistent between OSs
b) removes dependency information (pkg-config cannot detect that libSM will not
work without libICE)
c) cannot handle libICE headers being installed in a different location (e.g.
by overriding PKG_CONFIG_PATH for a test version).

Changed in libsm (Ubuntu):
importance: Undecided → Low
status: Incomplete → Confirmed
Revision history for this message
Robert Ancell (robert-ancell) wrote :

(Note that this is not critical as anything using libSM should work in an Ubuntu system as it currently stands as the headers are still includable and ld will automatically link against libICE via libSM)

Revision history for this message
Robert Ancell (robert-ancell) wrote :

This change is allowed - a user of libsm does not have to explicitly link to libsm. See the pkg-config author's post on this matter:
http://err.no/personal/blog/2008/Mar/25

Changed in libsm (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

This is still a deviation from upstream's .pc file, and it did break compilation of g-t for some user. Is there ANY justification for deviating from upstream here?

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I don't see the value in changing it and it should surely have been done upstream instead. However the change is legal and the example given should explicitly require libICE as it has libICE references inside of it. This will have to be argued in Debian if this is to change as they are our upstream in this regard.

affects: libsm (Ubuntu) → gnome-games (Ubuntu)
Changed in gnome-games (Ubuntu):
status: Invalid → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-games - 1:2.29.1-0ubuntu1

---------------
gnome-games (1:2.29.1-0ubuntu1) lucid; urgency=low

  * New upstream release (LP: #455980)
    - Blackjack no longer distributed
    - Same GNOME renamed to Swell Foop and written in Javascript
    - Gnometris renamed to Quadrapassel
    - No longer uses GGZ
  * debian/control.in:
    - Remove blackjack, add lightsoff, rename gnometris and same-gnome
    - Remove build-depends on GGZ
    - Drop build-depends on libxml2-dev, libggzmod-dev, libggzdmod-dev,
      libggz-gtk-dev
    - Add build-depends on gobject-introspection, libgirepository1.0-dev,
      gobject-introspection-repository, gobject-introspection-glib-2.0,
      gobject-introspection-freedesktop, libclutter-gtk-0.10-dev
  * debian/gnome-blackjack.install:
  * debian/gnome-blackjack.menu:
    - Blackjack no longer distributed
  * debian/gnometris.install:
  * debian/quadrapassel.install:
  * debian/pixmaps/gnometris.xpm:
  * debian/pixmaps/quadrapassel.xpm:
    - Gnometris renamed to Quadrapassel
  * debian/same-gnome.install:
  * debian/same-gnome.menu:
  * debian/swell-foop.install:
  * debian/swell-foop.menu:
  * debian/pixmaps/same-gnome.xpm:
  * debian/pixmaps/swell-foop.xpm:
    - Same GNOME renamed to Swell Foop
  * debian/gnect-server.installl:
  * debian/gnibbles-server.install:
  * debian/iagno-server.install:
    - No longer uses GGZ
  * debian/lightsoff.install:
  * debian/lightsoff.menu:
    - Add lightsoff package
  * debian/quadrapassel.menu:
    - Added missing menu file
  * debian/rules:
  * debian/gnome-games-common.install
    - Enable introspection
    - Remove obsolete GGZ configure flags
  * debian/patches/90_libice_pkgconfig.patch:
    - Pass linking flags for libICE usage in eggsmclient (LP: #455614)
  * debian/patches/91_gir_build.patch:
    - Build and install introspection files
  * debian/patches/92_swell_foop_tango_theme.patch:
    - Fix install location of theme
 -- Robert Ancell <email address hidden> Mon, 09 Nov 2009 18:00:20 +0100

Changed in gnome-games (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
c7d2f5c8667d26fffd5e7772d632c76d (c7d2f5c8667d26fffd5e7772d632c76d-deactivatedaccount) wrote :

How can a bug in libsm-dev be fixed by a new gnome-games upload? The buggy sm.pc file is still there!

Revision history for this message
Robert Ancell (robert-ancell) wrote :

gnome-games has been patched to request ICE build flags from pkg-config. While I agree Debian changing this file instead of getting upstream to do it is crazy it is the more technically correct behaviour. If you know a reason why gnome-games should not be linking against libICE please let me know.

Changed in gnome-games:
status: Unknown → Fix Released
Changed in gnome-games:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.