Launchpad itself

test.py runs all tests if working directory contains name of desired story

Bug #46324 reported by Matthew Paul Thomas
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
James Henstridge

Bug Description

"./test.py -f -vv canonical shipit" should run every test containing 'shipit' in their name, which is a good way of running all shipit tests, both normal doctests, and pagetests. Normally it does work, but if the working directory contains this string as well, for example 2006-05-shipit, all tests will be run.

This is a problem since you often want to run all tests related to what you're working on in the branch, and you often name the branch to what it's related to.

See original description
Revision history for this message
Brad Bollenbach (bradb) wrote :

I don't see a shipit story. Is this bug still valid?

And if there were a shipit story, you'd run it like:

python test.py canonical pagetests.shipit

Changed in launchpad:
status: Unconfirmed → Needs Info
Revision history for this message
Björn Tillenius (bjornt) wrote :

This bug is still valid. It doesn't have that much to do with pagetest. It's more like, I'd like to run all tests that have 'shipit' in their name. I often try to do these kind of things, and often it fails since my working directory contains that string as well.

Changed in launchpad:
status: Needs Info → Confirmed
Björn Tillenius (bjornt)
description: updated
Revision history for this message
Stuart Bishop (stub) wrote : Re: [Bug 46324] Re: test.py runs all tests if working directory contains name of desired story

Björn Tillenius wrote:
> This bug is still valid. It doesn't have that much to do with pagetest.
> It's more like, I'd like to run all tests that have 'shipit' in their
> name. I often try to do these kind of things, and often it fails since
> my working directory contains that string as well.

This has bitten me too. It might just require specifying more options on the
command line but I didn't bother digging too deeply at the time.

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

Matthew Paul Thomas (mpt)
Changed in launchpad:
assignee: nobody → barry
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Jamesh fixed this in RF 5792.

Changed in launchpad:
assignee: barry → jamesh
status: Confirmed → Fix Committed
Revision history for this message
James Henstridge (jamesh) wrote :

It isn't quite fixed. There are many fewer tests that include the base directory in their name but there are a few. I'll do a followup branch to get rid of the last few now that the infrastructure is in place.

Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
James Henstridge (jamesh) wrote :

The remaining fixes are in r5804.

Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.