Ubuntu
gpe-shield package

[FTBFS] open() needs mode in backend.c to compile in GCC 4.4

Bug #495448 reported by Alfonso Cepeda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gpe-shield (Debian)
Fix Released
Unknown
gpe-shield (Ubuntu)
Fix Released
Undecided
Andrew Starr-Bochicchio

Bug Description

Binary package hint: gpe-shield

Line 406 of backend.c has:

if ((fh = open(LOADRULES_MARK,O_CREAT | O_RDWR | O_TRUNC)) < 0)

but when O_CREAT parameter exists, the function needs the mode (rights) of the created file.

This prevents package to be built

If this line is changed by:

if ((fh = open(LOADRULES_MARK,O_CREAT | O_RDWR | O_TRUNC, S_IRUSR|S_IWUSR)) < 0)

the program compiles.

Tags: ftbfs
Revision history for this message
Alfonso Cepeda (cepeda) wrote :

debdiff

Revision history for this message
Chuck Short (zulcss) wrote :

Thanks for your bugfix I have uploaded it to the archvie.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gpe-shield - 0.31-3ubuntu1

---------------
gpe-shield (0.31-3ubuntu1) lucid; urgency=low

  * [FTBFS] open() needs mode if O_CREAT in backend.c to be build
    in GCC 4.4 (LP: #495448)

   [Chuck Short]
   * Update maintainer according to spec.
 -- Alfonso Cepeda Caballos <email address hidden> Fri, 11 Dec 2009 12:06:18 +0000

Changed in gpe-shield (Ubuntu):
status: New → Fix Released
Revision history for this message
Alfonso Cepeda (cepeda) wrote :

Hi:

I think the debdiff file has not been fully applied.

The diff uploaded:

http://launchpadlibrarian.net/36699922/gpe-shield_0.31-3_0.31-3ubuntu1.diff.gz

has not added the 040-open-mode.patch file that it is included in the diff of this bug thread

http://launchpadlibrarian.net/36691890/debdiff

Thanks

Changed in gpe-shield (Ubuntu):
status: Fix Released → New
Andrew Starr-Bochicchio (andrewsomething)
Changed in gpe-shield (Ubuntu):
status: New → In Progress
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gpe-shield - 0.31-3ubuntu2

---------------
gpe-shield (0.31-3ubuntu2) lucid; urgency=low

  * Really apply patch by Alfonso Cepeda.
   - debian/patches/040-open-mode.patch:
     open() needs mode if O_CREAT in backend.c to be build
     in GCC 4.4 (LP: #495448)
 -- Andrew Starr-Bochicchio <email address hidden> Fri, 11 Dec 2009 23:55:28 -0500

Changed in gpe-shield (Ubuntu):
status: In Progress → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gpe-shield (Debian):
status: Unknown → New
Bug Watch Updater (bug-watch-updater)
Changed in gpe-shield (Debian):
status: New → Won't Fix
Bug Watch Updater (bug-watch-updater)
Changed in gpe-shield (Debian):
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.