Please update wxbanker to 0.6.1.0

I wasn't sure exactly how to update the changelog appropriately since 0.6.0.0 is a separate entry but ubuntu will never see it; it will skip from 0.5 -> 0.6.1. If those entries should be rolled in to one let me know.

Attached is a diff.gz for http://launchpad.net/wxbanker/0.6/0.6.1/+download/wxbanker-0.6.1.0.tar.gz. Let me know if I haven't generated it correctly!

I think it would be preferable to not have a debian/changelog entry for 0.6.0.0. If someone really cares, they can get that information from the upstream changelog.

You also dropped an entry from the debian/changelog - version 0.5.0.0-0ubuntu2. Changelog entries should never be deleted.

Finally, the current version has XS-Python-Version: >= 2.5, << 3.0, but the version you've proposed only has XS-Python-Version: >= 2.5. Was that change intentional?

I've unsubscribed ubuntu-universe-sponsors for now, but feel free to re-subscribe when you've dealt with those things.

Thanks for the review, Evan! I've attached an updated diff.gz where I removed the 0.6.0.0 entry and synced with the downstream so as to have 0.5.0.0-0ubuntu2 (sorry about missing that, thanks for catching it!). Removing the << 3 for the Python dependency was intential; ScottK in #ubuntu-motu told me it was superfluous as that is already assumed by other tools somewhere in the chain, so as I understand it I don't need it.

How does it look now?

Sorry, two more things I missed on my first look through:

 - You dropped the debian/compat file - that's needed to inform debhelper's behavior

 - What...exactly are those postinsts and postrms doing? They don't appear to save anything locally or run anything locally, so I have to assume they're phoning home. That's...distinctly not OK. If you want data about how many people are installing your app, look at popcon.

Again, u-u-s unsubbed, but feel free to re-sub

Ah yes, the downstream packaging has a compat and pycompat which my upstream packaging didn't. Either I somehow lost them or perhaps whoever uploaded 0.5 silently fixed that for me. I've added the compat and pycompat back so it now has the same files as the 0.5 packaging. Is this correct?

I've also removed the postinst/postrm scripts; I can understand how these are not acceptable in packages in the Ubuntu archive. They are hitting a hook that counts installs including version and distro version. It is really useful information when I push them to PPAs since until bug #139855 is implemented, I otherwise have no way to know which distros and versions are the most popular, to ensure compatibility with. Without this data I'm programming in the dark; I don't know how important it is to maintain compatibility with dependency/distro versions as I don't know if 5% or 95% of users are using Jaunty for example. But, this is really most useful for PPAs and using popcon is indeed mostly good enough for the version shipped in a distro (alas, I lose the distro version information and accurate removal counts). I've updated my script which generates the .diff.gz to remove these so they won't appear in this or future uploaded versions!

Thanks again for your help, time, and review; how does it look now?

This all looks good - thanks for the revisions.

I'll sponsor the upload in a few minutes.

This bug was fixed in the package wxbanker - 0.6.1.0-0ubuntu1

---------------
wxbanker (0.6.1.0-0ubuntu1) lucid; urgency=low

  * New upstream release (LP: #504884):
   - recurring transactions
   - customizable summary graph timeframe
   - XDG support
   - new included currencies: SEK, UAH, MXN
   - many bug fixes: https://launchpad.net/wxbanker/+milestone/0.6
  * debian/control:
   - Add python-dateutil to Depends.
   - Add python-xdg to Recommends.
 -- Michael Rooney <email address hidden> Fri, 08 Jan 2010 10:31:52 -0800

Thanks so much for your time and help Evan!