grig crashes on mouse click between freq display digits

Bug #517816 reported by Kamal Mostafa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grig (Debian)
Fix Released
Unknown
grig (Ubuntu)
Fix Released
Undecided
Iulian Udrea

Bug Description

Binary package hint: grig

grig 0.7.2 Ubuntu Karmic

TESTCASE:
(Reproducible on amd64 but not i386)
1. Run grig
2. Mouse click in the space *between* the "145" and the "000" (not on any digit).
grig crashes with Segmentation fault.

Note also that mouse scroll-wheel-up events don't work (but scroll-wheel-down events do work) to change frequency digits.

Related branches

Changed in grig (Ubuntu):
assignee: nobody → Kamal Mostafa (kamalmostafa)
status: New → In Progress
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Attached branch fixes the bug, which is caused by an invalid (i >= 0) comparison with variable 'i' declared as unsigned.

Patch forwarded upstream to https://sourceforge.net/tracker/?func=detail&atid=384594&aid=2946859&group_id=25530

Will forward to Debian pending Ubuntu merge.

Changed in grig (Ubuntu):
assignee: Kamal Mostafa (kamalmostafa) → nobody
status: In Progress → Confirmed
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Update packages for Karmic and Lucid which include this fix are available in my PPA:

    https://launchpad.net/~kamalmostafa/+archive/grig-fixes

Iulian Udrea (iulian)
Changed in grig (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Iulian Udrea (iulian)
Revision history for this message
Iulian Udrea (iulian) wrote :

I have just uploaded it. Thank you for your contribution to Ubuntu!

Changed in grig (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grig - 0.7.2-3ubuntu1

---------------
grig (0.7.2-3ubuntu1) lucid; urgency=low

  * Fix segfault on mouse click between frequency digits (LP: #517816)
    - rig_gui_lcd_get_event_object: 'i' might go negative so must be signed.
 -- Kamal Mostafa <email address hidden> Fri, 05 Feb 2010 14:36:39 -0800

Changed in grig (Ubuntu):
status: Fix Committed → Fix Released
Changed in grig (Debian):
status: Unknown → New
Changed in grig (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.