[ubuntu-mono-dark] Inconsistent main color

Bug #620041 reported by Hernando Torque
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-themes (Ubuntu)
Expired
Low
Unassigned

Bug Description

Binary package hint: ubuntu-mono

The set uses those three main colors, when it should be just one like in ubuntu-mono-light: #DFD8C8, #EAE3D0, #EAE3D1.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: ubuntu-mono 0.0.19 [modified: usr/share/icons/ubuntu-mono-dark/apps/16/distributor-logo.svg usr/share/icons/ubuntu-mono-dark/apps/22/distributor-logo.svg usr/share/icons/ubuntu-mono-dark/apps/22/start-here.svg usr/share/icons/ubuntu-mono-dark/apps/24/distributor-logo.svg usr/share/icons/ubuntu-mono-dark/apps/24/start-here.svg]
ProcVersionSignature: Ubuntu 2.6.35-15.21-generic 2.6.35.1
Uname: Linux 2.6.35-15-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Wed Aug 18 20:34:43 2010
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: ubuntu-mono

Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Vish (vish) wrote :

Hmm , not really sure what this bug is about!

What colors are you referring to? Could you be more specific about which icons you had problems with?

Changed in ubuntu-mono (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Hernando Torque (htorque) wrote :

Ok, so ubunt-mono-dark has 358 SVG files (not counting links):

* 139 use the color #DFD8C8
* 125 use the color #EAE3D0
* 59 use the color #EAE3D1

Those "sets" are distinct, so no icon contains more than one of those colors. The remaining 35 icons are some kind of alert icons (mostly red) or deliberately use a darker beige (eg. the wireless network animation).

I definitely see a difference between #DFD8C8 and the brighter colors (see attached image), so I think #DFD8C8 should be the one to change.

I did NOT verify that all of those 139 darker icons are a real problem (I just 'grep'-ed for the colors, eg. krb-no-valid-ticket.svg uses the color with a very low opacity - so no real problem), but using 'sed' it should be easy to "batch-fix" them.

There are also 4 PNG files:

status/16/application-running.png -> uses #DFD8C8, easy to change
status/16/sound_icon.png -> hard to tell, but definitely brighter than #DFD8C8
status/22/application-running.png -> again #DFD8C8, easy to change
stock/64/album_artwork.png -> not relevant

Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Hernando Torque (htorque) wrote :
Revision history for this message
Hernando Torque (htorque) wrote :

Whatever your decision is, I now verified (visually) that there are no negative side effects when using 'sed' to replace any of those colors. I used it to change the three colors to something more distinguishable:

while read line; do sed -i "s/#dfd8c8/#0000ff/g" "$line"; done < dfd8c8.txt
while read line; do sed -i "s/#eae3d0/#00ffff/g" "$line"; done < eae3d0.txt
while read line; do sed -i "s/#eae3d1/#00ff00/g" "$line"; done < eae3d1.txt

and then checked all 358 SVGs. During that process I found eight additional icons that use different colors than the others in their sets:

./ubuntu-mono-dark/animations/22/nm-stage01-connecting01.svg -> ebe4d2
./ubuntu-mono-dark/animations/22/nm-stage01-connecting02.svg -> ebe4d1
./ubuntu-mono-dark/animations/22/nm-stage01-connecting03.svg -> e9e4d0
./ubuntu-mono-dark/animations/24/nm-stage01-connecting01.svg -> ebe4d2
./ubuntu-mono-dark/animations/24/nm-stage01-connecting02.svg -> ebe4d1
./ubuntu-mono-dark/animations/24/nm-stage01-connecting03.svg -> e9e4d0
./ubuntu-mono-dark/status/22/battery-020.svg -> ebe4d0
./ubuntu-mono-dark/status/22/battery-100-charging.svg -> ebe4d0

---

If you, for example, decide to make #eae3d0 the main color, the whole fixing would boil down to running the following commands from the package's root:

while read line; do sed -i "s/#dfd8c8/#eae3d0/g" "$line"; done < dfd8c8.txt
while read line; do sed -i "s/#eae3d1/#eae3d0/g" "$line"; done < eae3d1.txt
sed -i "s/#ebe4d2/#eae3d0/g" ./ubuntu-mono-dark/animations/22/nm-stage01-connecting01.svg
sed -i "s/#ebe4d1/#eae3d0/g" ./ubuntu-mono-dark/animations/22/nm-stage01-connecting02.svg
sed -i "s/#e9e4d0/#eae3d0/g" ./ubuntu-mono-dark/animations/22/nm-stage01-connecting03.svg
sed -i "s/#ebe4d2/#eae3d0/g" ./ubuntu-mono-dark/animations/24/nm-stage01-connecting01.svg
sed -i "s/#ebe4d1/#eae3d0/g" ./ubuntu-mono-dark/animations/24/nm-stage01-connecting02.svg
sed -i "s/#e9e4d0/#eae3d0/g" ./ubuntu-mono-dark/animations/24/nm-stage01-connecting03.svg
sed -i "s/#ebe4d0/#eae3d0/g" ./ubuntu-mono-dark/status/22/battery-020.svg
sed -i "s/#ebe4d0/#eae3d0/g" ./ubuntu-mono-dark/status/22/battery-100-charging.svg

That's it - all 358 _mono_ SVGs would use _one_ color (like ubuntu-mono-light). :-)

Vish (vish)
Changed in ubuntu-mono (Ubuntu):
status: Incomplete → New
Revision history for this message
Hernando Torque (htorque) wrote :

FWIW, I'm attaching a patch that corrects all colors in SVG files to #dfd8c8. I used sed to simply replace the following colors (touches 189 files):

#e9e4d0
#eae3d0
#eae3d1
#ebe4d0
#ebe4d1
#ebe4d2

That's simple color replacement - transparency or anything else doesn't get touched. I visually checked all 359 icons and they look fine to me, but I can understand if the sed-way is considered too risky.

The only PNG file that's not "dfd8c8-ified" is 'status/16/sound_icon.png' - I got no fix for that one.

tags: added: patch
Lucazade (lucazade)
Changed in ubuntu-mono (Ubuntu):
status: New → Confirmed
affects: ubuntu-mono (Ubuntu) → ubuntu-themes (Ubuntu)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thank you for reporting this bug to Ubuntu.
Ubuntu 10.10 (maverick) reached end-of-life on April 10, 2012.

See this document for currently supported Ubuntu releases:
https://wiki.ubuntu.com/Releases

We appreciate that this bug may be old and you might not be interested in discussing it any more. But if you are then please upgrade to the latest Ubuntu version and re-test.

Changed in ubuntu-themes (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for ubuntu-themes (Ubuntu) because there has been no activity for 60 days.]

Changed in ubuntu-themes (Ubuntu):
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.