Gwibber

gwibber-service creates a new worker pool of threads/processes for each async request that it decided to do

Bug #624918 reported by Tom "spot" Callaway on 2010-08-26

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Gwibber	Fix Released	Undecided	Ken VanDine	Gwibber 2.32.0
	gwibber (Ubuntu)	Fix Released	Undecided	Ken VanDine

Bug Description

In the latest gwibber trunk code, gwibber was causing the system to max out on available threads, specifically because gwibber-service was creating a new worker pool of threads/processes for each async request that it decided to do. Attached is a patch which resolves the issue, and does some minor cleanups.

Related branches

lp:ubuntu/maverick/gwibber

lp:~webapps/+junk/gwibber-opensesame-packaging

Revision history for this message

Tom "spot" Callaway (tcallawa) wrote on 2010-08-26:

gwibber-825bzr-threads-gone-wild.patch Edit (2.9 KiB, text/plain)

Revision history for this message

Vadim Rutkovsky (roignac) wrote on 2010-08-26:

I tried the patch, the only difference I've noted, is that loading has become slower.
Anybody else tried this?

Ken VanDine (ken-vandine) on 2010-08-26

Changed in gwibber:
assignee:	nobody → Ken VanDine (ken-vandine)

Revision history for this message

Ken VanDine (ken-vandine) wrote on 2010-09-08:

I am not seeing any slowdown, I am doing some memory profiling to make sure it is no worse on memory usage than without the patch

Ken VanDine (ken-vandine) on 2010-09-08

Changed in gwibber:
milestone:	none → 2.32.0
status:	New → Triaged
status:	Triaged → Fix Committed

Ken VanDine (ken-vandine) on 2010-09-09

Changed in gwibber (Ubuntu):
assignee:	nobody → Ken VanDine (ken-vandine)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-09-09:

This bug was fixed in the package gwibber - 2.31.92-0ubuntu1

---------------
gwibber (2.31.92-0ubuntu1) maverick; urgency=low

  * New upstream release
    - Don't crash if there are streams configured for accounts that no longer
      exist (LP: #631263)
    - Delete associated streams when an account is deleted
    - Reuse worker pool of threads (LP: #624918)
    - Ensure the timer is reset on each refresh, prevents multiple timers
      created to perform the refresh operations causing crashes (LP: #600010)
    - Clicking on the message indicator should focus replies (LP: #549817)
    - When focusing replies stream from the indicator, clear the
      indicators (LP: #629623)
    - gwibber-service crashed with IOError in get_avatar_path() (LP: #626068)
    - gwibber-service crashed with GError in notify() (LP: #622812)
  * debian/gwibber-service.py
    - Added apport package-hook to attach the gwibber.log (LP: #384552)
-- Ken VanDine <email address hidden> Fri, 03 Sep 2010 15:06:17 -0400